Skip to content

UPSTREAM: 80004: Prefer to delete doubled-up pods of a ReplicaSet#24047

Closed
p0lyn0mial wants to merge 1 commit intoopenshift:masterfrom
p0lyn0mial:bring-80004-back
Closed

UPSTREAM: 80004: Prefer to delete doubled-up pods of a ReplicaSet#24047
p0lyn0mial wants to merge 1 commit intoopenshift:masterfrom
p0lyn0mial:bring-80004-back

Conversation

@p0lyn0mial
Copy link
Contributor

brings back #23806

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 29, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: p0lyn0mial
To complete the pull request process, please assign bparees
You can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@p0lyn0mial
Copy link
Contributor Author

/hold

not clear if we want to merge it again - #23806 (comment)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2019
@sttts
Copy link
Contributor

sttts commented Oct 29, 2019

/assign @Miciah @tnozicka

@openshift-ci-robot
Copy link

@p0lyn0mial: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-cmd a518181 link /test e2e-cmd
ci/prow/unit a518181 link /test unit
ci/prow/e2e-gcp a518181 link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tnozicka
Copy link
Contributor

/hold
the PR "conveniently" nuked by rebase broke https://prow.svc.ci.openshift.org/job-history/origin-ci-test/logs/release-openshift-openshift-ansible-e2e-aws-scaleup-rhel7-4.3 - we shouldn't merge it before the author (@Miciah) fixes the CI flake which seemed permanent on that periodic

@tnozicka
Copy link
Contributor

@Miciah
Copy link
Contributor

Miciah commented Oct 30, 2019

I created #24057, which supersedes this PR and includes a fix for https://bugzilla.redhat.com/show_bug.cgi?id=1765756.

@p0lyn0mial
Copy link
Contributor Author

I created #24057, which supersedes this PR

okay, so I am closing this PR then, thx.

@p0lyn0mial p0lyn0mial closed this Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants