os/Dockerfile: Use dnf, pin repos, and clean cache #23613

ashcrow · 2019-08-15T16:02:38Z

Clean the dnf/yum cache before running commands
Pin Fedora repos
Call dnf directly instead of yum

ashcrow · 2019-08-15T16:22:09Z

Error getting repository data for built, repository not found

ashcrow · 2019-08-15T16:30:47Z

I'm looking to see where built.repo is defined. I'm wondering if it may have been accidentally removed somewhere but is still expected by this build.

ashcrow · 2019-08-15T16:52:08Z

Looks like f29 required in the name for other dependencies in the CI set up. Switched back to f29 to see if it passes.

ashcrow · 2019-08-15T17:27:54Z

Looking to pin repos instead of using mirrors.

- Clean the dnf/yum cache before running commands - Call dnf directly instead of yum - Pin to a specific set of Fedora repos

ashcrow · 2019-08-15T19:27:34Z

/test e2e-cmd

ashcrow · 2019-08-15T19:29:03Z

/test e2e-aws

ashcrow · 2019-08-15T19:31:29Z

The image builds fine, just need to get past the other CI targets.

ashcrow · 2019-08-15T20:25:39Z

/cc @jlebon

ashcrow · 2019-08-16T15:16:02Z

/test e2e-cmd

ashcrow · 2019-08-16T16:03:38Z

no such image 😕

/test e2e-cmd

jlebon · 2019-08-16T16:10:30Z

Is the motivation here using mirrors because they can flake? If a build observes many of them failing in a single run, there might something else wrong which using a specific mirror won't fix.

ashcrow · 2019-08-16T16:13:26Z

@jlebon more or less yes. The Fedora mirrors have been flaky at random times causing significant failures.

ashcrow · 2019-08-16T17:09:02Z

s: "error waiting for the pod 'test-cmd' to complete: the pod errored trying to run the command",

/test e2e-cmd

ashcrow · 2019-08-19T20:55:42Z

/test e2e-cmd

ashcrow · 2019-08-20T13:20:45Z

Failed:

[Suite:openshift/test-cmd][Serial][Disruptive] test-cmd: test/cmd/policy-storage-admin.sh [Suite:openshift] expand_less

/test e2e-cmd

cgwalters · 2019-08-20T14:28:45Z

Ultimately though, if we're going to use Fedora content in CI, we need to make the mirroring more robust, not work around it at every call site.

That said another way to work around this would be changing the system to use coreos-assembler instead like openshift/machine-config-operator#682

ashcrow · 2019-08-20T15:10:51Z

Ultimately though, if we're going to use Fedora content in CI, we need to make the mirroring more robust, not work around it at every call site.

True. This PR is attempting to work around the pain for the short term, not a forever fix.

vrutkovs · 2019-09-10T14:10:56Z

FAILURE after 0.000s: test/cmd/basicresources.sh:175: executing 'oc set probe -f /var/tests/test/cmd/testdata/hello-openshift/hello-pod.json --local -o yaml --liveness --get-url=https://127.0.0.1:port/path' expecting success and text 'port: port': the command returned the wrong error code; the output content test failed
There was no output from the command.
Standard error from the command:
error: --get-url could not be parsed as a valid URL: parse https://127.0.0.1:port/path: invalid port ":port" after host
[ERROR] hack/lib/cmd.sh:241: `return "${return_code}"` exited with status 1.

/retest

jlebon · 2019-10-03T15:56:59Z

I guess if it helps in the short-term...
/approve

(But again, it's not clear to me if this would fix the original issue. IIRC, multiple mirrors were failing in a single run, right?)

openshift-ci-robot · 2019-10-03T15:57:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashcrow, jlebon
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

images/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2019-10-20T00:20:08Z

@ashcrow: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-upgrade	`7fb6654`	link	`/test e2e-gcp-upgrade`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-01-18T11:54:15Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-ci-robot · 2020-01-18T11:54:22Z

@ashcrow: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-02-17T13:38:01Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2020-03-18T17:40:19Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot · 2020-03-18T17:40:21Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2019

openshift-ci-robot requested review from pweil- and sdodson August 15, 2019 16:03

ashcrow force-pushed the clean-cache-and-use-f30 branch from 59cc9aa to 0896ba7 Compare August 15, 2019 16:51

ashcrow changed the title ~~WIP: os/Dockerfile: Use F30, dnf, and clean cache~~ WIP: os/Dockerfile: Use dnf and clean cache Aug 15, 2019

os/Dockerfile: Use dnf, pin yum repos, and clean cache

7fb6654

- Clean the dnf/yum cache before running commands - Call dnf directly instead of yum - Pin to a specific set of Fedora repos

ashcrow force-pushed the clean-cache-and-use-f30 branch from 0896ba7 to 7fb6654 Compare August 15, 2019 17:34

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2019

ashcrow changed the title ~~WIP: os/Dockerfile: Use dnf and clean cache~~ os/Dockerfile: Use dnf and clean cache Aug 15, 2019

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2019

ashcrow changed the title ~~os/Dockerfile: Use dnf and clean cache~~ os/Dockerfile: Use dnf, pin repos, and clean cache Aug 15, 2019

openshift-ci-robot requested a review from jlebon August 15, 2019 20:25

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 18, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2020

openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 17, 2020

openshift-ci-robot closed this Mar 18, 2020

os/Dockerfile: Use dnf, pin repos, and clean cache #23613

os/Dockerfile: Use dnf, pin repos, and clean cache #23613

Uh oh!

Conversation

ashcrow commented Aug 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashcrow commented Aug 15, 2019

Uh oh!

ashcrow commented Aug 15, 2019

Uh oh!

ashcrow commented Aug 15, 2019

Uh oh!

ashcrow commented Aug 15, 2019

Uh oh!

ashcrow commented Aug 15, 2019

Uh oh!

ashcrow commented Aug 15, 2019

Uh oh!

ashcrow commented Aug 15, 2019

Uh oh!

ashcrow commented Aug 15, 2019

Uh oh!

ashcrow commented Aug 16, 2019

Uh oh!

ashcrow commented Aug 16, 2019

Uh oh!

jlebon commented Aug 16, 2019

Uh oh!

ashcrow commented Aug 16, 2019

Uh oh!

ashcrow commented Aug 16, 2019

Uh oh!

ashcrow commented Aug 19, 2019

Uh oh!

ashcrow commented Aug 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cgwalters commented Aug 20, 2019

Uh oh!

ashcrow commented Aug 20, 2019

Uh oh!

vrutkovs commented Sep 10, 2019

Uh oh!

jlebon commented Oct 3, 2019

Uh oh!

openshift-ci-robot commented Oct 3, 2019

Uh oh!

openshift-ci-robot commented Oct 20, 2019

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-ci-robot commented Jan 18, 2020

Uh oh!

openshift-bot commented Feb 17, 2020

Uh oh!

openshift-bot commented Mar 18, 2020

Uh oh!

openshift-ci-robot commented Mar 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ashcrow commented Aug 15, 2019 •

edited

Loading

ashcrow commented Aug 20, 2019 •

edited

Loading