Bug 1739445: Remove oc rpms #23567

tnozicka · 2019-08-07T15:50:31Z

Those RPMs have moved into oc repo. We are now trying to switch ART team to use them but we shouldn't build from 2 places at once.

hyperkube needs to stay for providing kubelet to the base image. (

origin/images/os/Dockerfile

Line 7 in 7aedc3c

    
           yumdownloader --enablerepo=built --destdir=/tmp/rpms openshift-hyperkube openshift-clients && \

)

/cc @smarterclayton @eparis @deads2k @soltysh

tnozicka · 2019-08-07T15:56:21Z

/hold
(for a sync with https://jira.coreos.com/browse/ART-844) when this is tagged)

tnozicka · 2019-08-07T16:19:22Z

/retest

tnozicka · 2019-08-08T13:19:48Z

/retest

tnozicka · 2019-08-08T14:25:27Z

rpm repos timeouts for other packages
/retest

tnozicka · 2019-08-08T14:37:41Z

/retest

tnozicka · 2019-08-08T14:48:13Z

/retest

tnozicka · 2019-08-09T07:24:00Z

/retest

tnozicka · 2019-08-09T08:30:58Z

https://mirror.umd.edu/fedora/linux/updates/29/Modular/x86_64/repodata/5ddd47c03de6cd5e4b1d102c96f23f7e794c404611c49820745047dfbfbd4320-primary.xml.gz: [Errno 14] HTTPS Error 404 - Not Found
Trying other mirror.
No Match for argument openshift-clients
++ find /tmp/rpms/ -name 'openshift-*' -iname '*.rpm'

sounds like we don't support cross repo rpms

openshift-ci-robot · 2019-08-09T10:35:36Z

@tnozicka: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1739445: Remove oc rpms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tnozicka · 2019-08-09T10:57:39Z

It is failing on missing openshift-clients package - not sure what to do to make it pull a promoted RPM from oc repo like images do... @smarterclayton ideas?

tnozicka · 2019-08-09T14:22:56Z

/cc @stevekuznetsov

stevekuznetsov

What is the chain of dependencies here? What is the base image? Which repo are you trying to use?

stevekuznetsov · 2019-08-13T17:43:26Z

images/os/Dockerfile

    mkdir /tmp/working && cd /tmp/working && \
-    yumdownloader --enablerepo=built --destdir=/tmp/rpms openshift-hyperkube openshift-clients && \
+    PACKAGES=(openshift-hyperkube openshift-clients) && \
+    yumdownloader --enablerepo=built --destdir=/tmp/rpms ${PACKAGES[@]}  && \


If you are using [@] you must use double quotes or it's useless.

stevekuznetsov · 2019-08-13T17:44:33Z

If you're trying to install RPMs built in a different repo from the ephemeral RPM server, then no, that does not work.

tnozicka · 2019-08-14T11:36:04Z

If you're trying to install RPMs built in a different repo from the ephemeral RPM server, then no, that does not work.

Sounds like a blocker for 4.2; given oc lives in openshift/oc and it needs to be installed into machine-os image build from origin, we need a way to promote those as we do for images. Can DPTP team help support promoting RPMs?

stevekuznetsov · 2019-08-14T15:53:52Z

Can you build machine-os-content from openshift/oc?

stevekuznetsov · 2019-08-14T15:54:06Z

Or, we could move openshift/oc back into this repo.

deads2k · 2019-08-19T14:01:43Z

Or, we could move openshift/oc back into this repo.

No. That is an anti-goal. The two are separate and upstream is pushing them even further apart.

Can you build machine-os-content from openshift/oc?

What does machine-os-content mean?

How about we simply eliminate the Requires of clients? There's not actual need for a dependency between them.

tnozicka · 2019-08-20T15:16:35Z

/retest

tnozicka · 2019-08-20T15:23:43Z

/test images

tnozicka · 2019-08-20T15:56:43Z

/retest

tnozicka · 2019-08-22T10:31:46Z

talked to @smarterclayton and we can drop the oc from the machine-os-image as nothing in CI uses it and ART will install oc there

soltysh

/lgtm
/approve

soltysh

/lgtm

openshift-ci-robot · 2019-08-22T12:15:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tnozicka · 2019-08-22T13:48:33Z

/test e2e-aws

tnozicka · 2019-08-22T14:56:43Z

test-cmd should be fixed by #23649
/test e2e-cmd

soltysh · 2019-08-22T16:12:23Z

/retest

sosiouxme · 2019-08-22T16:30:32Z

At this point, if an image needs an oc client, we would prefer copying it over from ose-cli image rather than picking it up as an RPM.

That doesn't really matter here, though, as we still need to produce a client RPM, it just needs to come from a different location.

soltysh · 2019-08-22T18:56:28Z

That doesn't really matter here, though, as we still need to produce a client RPM, it just needs to come from a different location.

@sosiouxme not quite, aside from the binary RPM must deliver man pages, I don't think we put those in the image, although maybe we should. @tnozicka can you check if we do and update our image to have it? That'd be
a) handy for users to have man there
b) handy for art

sosiouxme · 2019-08-23T04:22:24Z

We actually had a bug open about oc not having man pages - I think we passed it on, but it is certainly desirable for oc to have man pages wherever it might be used by a human.

tnozicka · 2019-08-23T08:55:33Z

/retest

tnozicka · 2019-08-23T09:01:36Z

I am not sure about copying it out from the image. What if the man pages or some of the shared libraries differ? We link differently for RHEL, more dynamically and with special libraries. If we need to install those into both RHEL 7 and 8 those libraries and man pages could differ and we have the CLI image build just for one of them, so copying it out might not be the safest option.

tnozicka · 2019-08-23T11:08:33Z

/retest

tnozicka · 2019-08-23T14:28:25Z

ok, this is ready to be unhold when ART switches the oc RPM to be built from oc repo

tnozicka · 2019-08-28T18:57:53Z

https://jira.coreos.com/browse/ART-844 is done
/hold cancel

openshift-bot · 2019-08-29T00:21:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-08-29T02:58:56Z

@tnozicka: All pull requests linked via external trackers have merged. Bugzilla bug 1739445 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1739445: Remove oc rpms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from deads2k, eparis, smarterclayton and soltysh August 7, 2019 15:50

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 7, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2019

tnozicka changed the title ~~Remove oc rpms~~ Bug 1739445: Remove oc rpms Aug 9, 2019

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 9, 2019

openshift-ci-robot requested a review from stevekuznetsov August 9, 2019 14:22

stevekuznetsov reviewed Aug 13, 2019

View reviewed changes

tnozicka force-pushed the remove-oc-rpms branch from 7df6bda to 237f03c Compare August 20, 2019 14:25

tnozicka force-pushed the remove-oc-rpms branch from f4c164a to 9bca06d Compare August 22, 2019 10:45

soltysh approved these changes Aug 22, 2019

View reviewed changes

openshift-ci-robot assigned soltysh Aug 22, 2019

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 22, 2019

tnozicka added 2 commits August 22, 2019 14:04

Error out on missing packages

db6d5ed

Remove oc rpms

1412739

tnozicka force-pushed the remove-oc-rpms branch from 9bca06d to 1412739 Compare August 22, 2019 12:04

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2019

soltysh approved these changes Aug 22, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2019

openshift-merge-robot merged commit b9b9b93 into openshift:master Aug 29, 2019

tnozicka deleted the remove-oc-rpms branch August 29, 2019 05:43

tnozicka mentioned this pull request Aug 29, 2019

Remove oc from origin #23626

Merged

Bug 1739445: Remove oc rpms #23567

Bug 1739445: Remove oc rpms #23567

Uh oh!

Conversation

tnozicka commented Aug 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tnozicka commented Aug 7, 2019

Uh oh!

tnozicka commented Aug 7, 2019

Uh oh!

tnozicka commented Aug 8, 2019

Uh oh!

tnozicka commented Aug 8, 2019

Uh oh!

tnozicka commented Aug 8, 2019

Uh oh!

tnozicka commented Aug 8, 2019

Uh oh!

tnozicka commented Aug 9, 2019

Uh oh!

tnozicka commented Aug 9, 2019

Uh oh!

openshift-ci-robot commented Aug 9, 2019

Uh oh!

tnozicka commented Aug 9, 2019

Uh oh!

tnozicka commented Aug 9, 2019

Uh oh!

stevekuznetsov left a comment

Choose a reason for hiding this comment

Uh oh!

stevekuznetsov Aug 13, 2019

Choose a reason for hiding this comment

Uh oh!

stevekuznetsov commented Aug 13, 2019

Uh oh!

tnozicka commented Aug 14, 2019

Uh oh!

stevekuznetsov commented Aug 14, 2019

Uh oh!

stevekuznetsov commented Aug 14, 2019

Uh oh!

deads2k commented Aug 19, 2019

Uh oh!

tnozicka commented Aug 20, 2019

Uh oh!

tnozicka commented Aug 20, 2019

Uh oh!

tnozicka commented Aug 20, 2019

Uh oh!

tnozicka commented Aug 22, 2019

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Aug 22, 2019

Uh oh!

tnozicka commented Aug 22, 2019

Uh oh!

tnozicka commented Aug 22, 2019

Uh oh!

soltysh commented Aug 22, 2019

Uh oh!

sosiouxme commented Aug 22, 2019

Uh oh!

soltysh commented Aug 22, 2019

Uh oh!

sosiouxme commented Aug 23, 2019

Uh oh!

tnozicka commented Aug 23, 2019

Uh oh!

tnozicka commented Aug 23, 2019

Uh oh!

tnozicka commented Aug 23, 2019

Uh oh!

tnozicka commented Aug 23, 2019

tnozicka commented Aug 7, 2019 •

edited

Loading