Bug 1709958: test/e2e/upgrade: Add ingress controller test

[Miciah]

The test fails if the route is unavailable before or after an upgrade. For now, the test only logs if the test is unavailable during an upgrade.

• test/e2e/upgrade/ingress_controller.go: New file. Test that the default ingress controller is available before, during, and after an upgrade.
• test/e2e/upgrade/upgrade.go (AllTests): Add IngressControllerUpgradeTest.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Miciah
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tnozicka

If they are not already assigned, you can assign the PR to them by writing /assign @tnozicka in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Miciah]

/retest

[Miciah]

With the last test run, I see more or less the expected behavior:

step	timestamp	code
hitting the route
	22:58:46	503
	...	last code repeated
	22:58:51	503
	22:58:52	200
continuously hitting the route
	...	last code repeated
	23:16:36	200
	23:16:38	000
	...	last code repeated
	23:20:07	000
	23:20:10	200
	23:20:12	000
	...	last code repeated
	23:20:15	000
	23:20:18	200
	23:20:20	000
	23:20:23	200
	...	last code repeated
	23:42:26	200
	23:42:45	503
	23:42:47	200
	...	last code repeated
	23:46:22	200
	23:47:25	000
	23:47:28	503
	...	last code repeated
	23:47:33	503
	23:47:35	200
	...	last code repeated
	23:50:17	200
hitting the route again

After the test is set up, it starts running, and we see steady 200 responses for about 18 minutes. Then we see the route failing from 23:16:38 to 23:20:10 (and the log output has INFO: got error for route messages, as expected). After that, it is again returning 200 responses, with a few blips.

I would like to proceed as follows:

1. Merge this PR.
2. Merge Add shell script for graceful shutdown router#28.
3. Merge Bug 1709958: Use graceful shutdown for router cluster-ingress-operator#240.
4. Rerun this test and verify that there is no longer an outage.
5. Update this test to fail if the route becomes unavailable during upgrade (see the TODO in this PR).

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[Miciah]

/close
The E2E test added in #24057 should suffice.

[openshift-ci-robot]

@Miciah: Closed this PR.

Details

In response to this:

/close
The E2E test added in #24057 should suffice.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.