Skip to content

extract_tools: avoid error with --command #22636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markmc wants to merge 1 commit into from
Closed

extract_tools: avoid error with --command #22636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/oc/cli/admin/release/extract_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,15 +361,15 @@ func (o *ExtractOptions) extractCommand(command string) error {
klog.V(2).Infof("Unable to set extracted file modification time: %v", err)
}

// calculate hashes
if hash != nil {
func() {
extractLock.Lock()
defer extractLock.Unlock()
// calculate hashes and mark target as processed
func() {
extractLock.Lock()
defer extractLock.Unlock()
if hash != nil {
hashByTargetName[layer.Mapping.To] = hex.EncodeToString(hash.Sum(nil))
delete(targetsByName, layer.Mapping.Name)
}()
}
}
delete(targetsByName, layer.Mapping.Name)
}()

return false, nil
}
Expand Down