Skip to content

oc rsync: fix tar strategy #22552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 13, 2019
Merged

oc rsync: fix tar strategy #22552

openshift-merge-robot merged 1 commit into from
Apr 13, 2019

Conversation

@sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Apr 11, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2019
@sanchezl sanchezl requested a review from adambkaplan April 11, 2019 18:23
@adambkaplan
Copy link
Contributor

adambkaplan commented Apr 11, 2019

/lgtm

/assign @soltysh

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@enj
Copy link
Contributor

enj commented Apr 11, 2019

/lgtm

/assign @soltysh

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 11, 2019

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2019
@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 12, 2019

/test unit

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 12, 2019

/test e2e-aws-serial

soltysh
soltysh approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, enj, sanchezl, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Apr 12, 2019

@sanchezl new bugzilla for 4.2 to provide an e2e test to make sure we don't break it again

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 12, 2019

/test e2e-aws-serial

1 similar comment
@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 12, 2019

/test e2e-aws-serial

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 12, 2019

/retest

1 similar comment
@deads2k
Copy link
Contributor

deads2k commented Apr 12, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bedcd9e into openshift:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enj enj Awaiting requested review from enj

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@adambkaplan adambkaplan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sanchezl @adambkaplan @enj @openshift-ci-robot @deads2k @openshift-bot @soltysh @openshift-merge-robot