UPSTREAM: 76189: Fix flaky legacy pod autoscaler test #22490
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
soltysh
force-pushed
the
fix_legacy_podautoscaler
branch
from
9e2f4ed to
c510a9b
Compare
|
/test unit |
|
/test unit |
| return true, &v1.Event{}, nil | ||
| } | ||
| obj := action.(core.CreateAction).GetObject().(*v1.Event) | ||
| obj, ok := action.(core.CreateAction).GetObject().(*v1.Event) |
There was a problem hiding this comment.
So the client-go code says the same event (without defining what the same means) is patched when it's has been already recorded [1]. The fix would be then to allow to accept even Patch events. Hoping the Reason will stay the same. Or, just ignore any patch event.
soltysh
force-pushed
the
fix_legacy_podautoscaler
branch
from
c510a9b to
56740a7
Compare
soltysh
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
That unit flake is a separate one. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
| obj := action.(core.CreateAction).GetObject().(*v1.Event) | ||
| create, ok := action.(core.CreateAction) | ||
| if !ok { | ||
| return false, nil, nil |
There was a problem hiding this comment.
Per
// ReactionFunc is a function that returns an object or error for a given
// Action. If "handled" is false, then the test client will ignore the
// results and continue to the next ReactionFunc.
lgtm. Just ignoring every patch operation.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, ingvagabund, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
Force merging to unblock the queue (all tests passed once) |
6 participants
No description provided.