Clean up disabled tests #22460

jsafrane · 2019-04-03T08:35:53Z

See the commit messages, short overview:

All tests that need specific cloud have proper Skip().
Feature:BlockVolume does not match any tests - it was removed from all block tests when the feature graduated to beta.
Remove rules that don't match anything
Enable tests that depend on 1.13 kubelet

@openshift/sig-storage

jsafrane · 2019-04-03T15:51:35Z

/retest

wongma7 · 2019-04-03T20:00:07Z

/lgtm
ty

jsafrane · 2019-04-04T07:37:09Z

/test e2e-aws

jsafrane · 2019-04-04T07:37:16Z

/test e2e-aws-serial

jsafrane · 2019-04-04T08:31:02Z

/retest

jsafrane · 2019-04-04T08:44:50Z

/retest

jsafrane · 2019-04-05T10:48:08Z

/assign @mfojtik @knobunc
for approval

jsafrane · 2019-04-10T12:37:36Z

/test e2e-aws-serial
/test e2e-aws

jsafrane · 2019-04-10T14:25:09Z

/test e2e-aws-serial e2e-aws

jsafrane · 2019-04-10T15:07:52Z

/test e2e-aws

jsafrane · 2019-04-10T15:18:44Z

/retest

jsafrane · 2019-04-15T08:59:17Z

rebased, PTAL again please.

jsafrane · 2019-04-15T12:35:54Z

no storage failures
/retest

bertinatto · 2019-04-17T12:11:44Z

/lgtm

Edit: needs rebase, though:

<<<<<<< enable-cloud-tests

			`Kubelet when scheduling a busybox Pod with hostAliases should write entries to /etc/hosts`, // https://bugzilla.redhat.com/show_bug.cgi?id=1695278
=======
			`CSI Volumes CSI plugin test using CSI driver: hostPath`,
			`Volume metrics should create volume metrics in Volume Manager`,
>>>>>>> master

mfojtik · 2019-04-18T13:45:14Z

test/extended/util/test.go

 			`DNS configMap`, // this tests dns federation configuration via configmap, which we don't support yet

-			// vSphere tests can be skipped generally
-			`vsphere`,


huh, we no longer have vsphere test?

mfojtik · 2019-04-18T13:45:27Z

/cc @smarterclayton

smarterclayton · 2019-04-18T13:57:50Z

/hold

This looks like it substantially increased test runtime.

Can you add a before after diff of the tests you enabled for both parallel and serial?

smarterclayton · 2019-04-18T13:59:38Z

It might just be a transient, regardless when it rebases we need to be roughly the same amount of time for the run

openshift-ci-robot · 2019-05-12T02:47:55Z

@jsafrane: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-05-28T11:02:55Z

New changes are detected. LGTM label has been removed.

openshift-ci-robot · 2019-05-28T11:03:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jsafrane · 2019-05-28T11:08:34Z

Rebased to 1.14.

This looks like it substantially increased test runtime.

I don't see any increase (openshift/conformance/parallel was actually slower before the PR than it is now, I blame low nr. of samples).

There are two new real tests:

"[sig-storage] GCP Volumes GlusterFS should be mountable [Suite:openshift/conformance/parallel] [Suite:k8s]"
"[sig-storage] PersistentVolumes NFS when invoking the Recycle reclaim policy should test that a PV becomes Available and is clean after the PVC is deleted. 
[Suite:openshift/conformance/parallel] [Suite:k8s]"

Additional 37 tests are skipped (missing vsphere), each Skip() takes 2-3 seconds for BeforeEach + AfterEach ( divide by nr. of parallel tests).

jsafrane · 2019-05-28T11:09:30Z

/reopen

openshift-ci-robot · 2019-05-28T11:09:31Z

@jsafrane: Failed to re-open PR: state cannot be changed. There are no new commits on the jsafrane:enable-cloud-tests branch.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane · 2019-05-28T11:15:42Z

I accidentally pushed 0 commits to this PR and github does not let me to reopen this. Posted new PR #22912

openshift-ci-robot · 2019-05-28T11:38:02Z

@jsafrane: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	`f3c7ab3`	link	`/test e2e-aws`
ci/prow/e2e-aws-serial	`f3c7ab3`	link	`/test e2e-aws-serial`
ci/prow/e2e-aws-upgrade	`f3c7ab3`	link	`/test e2e-aws-upgrade`
ci/prow/images	`f3c7ab3`	link	`/test images`
ci/prow/cmd	`f3c7ab3`	link	`/test cmd`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot added sig/storage size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2019

openshift-ci-robot requested review from bparees and danwinship April 3, 2019 08:36

jsafrane changed the title ~~Enable cloud-based storage tests~~ Clean up disabled tests Apr 3, 2019

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2019

jsafrane mentioned this pull request Apr 3, 2019

Enable GlusterFS tests #22459

Closed

jsafrane force-pushed the enable-cloud-tests branch from 3503535 to 33d61b6 Compare April 3, 2019 11:36

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2019

openshift-ci-robot assigned wongma7 Apr 3, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2019

openshift-ci-robot assigned knobunc and mfojtik Apr 5, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2019

jsafrane force-pushed the enable-cloud-tests branch from 33d61b6 to 30004d0 Compare April 15, 2019 08:59

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 15, 2019

openshift-ci-robot assigned bertinatto Apr 17, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019

mfojtik reviewed Apr 18, 2019

View reviewed changes

openshift-ci-robot requested a review from smarterclayton April 18, 2019 13:45

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2019

jsafrane closed this May 28, 2019

jsafrane force-pushed the enable-cloud-tests branch from 30004d0 to f3c7ab3 Compare May 28, 2019 11:02

jsafrane unassigned wongma7 May 28, 2019

openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 28, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2019

jsafrane mentioned this pull request May 28, 2019

Clean up disabled tests #2 #22912

Merged

Clean up disabled tests #22460

Clean up disabled tests #22460

Uh oh!

Conversation

jsafrane commented Apr 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsafrane commented Apr 3, 2019

Uh oh!

wongma7 commented Apr 3, 2019

Uh oh!

jsafrane commented Apr 4, 2019

Uh oh!

jsafrane commented Apr 4, 2019

Uh oh!

jsafrane commented Apr 4, 2019

Uh oh!

jsafrane commented Apr 4, 2019

Uh oh!

jsafrane commented Apr 5, 2019

Uh oh!

jsafrane commented Apr 10, 2019

Uh oh!

jsafrane commented Apr 10, 2019

Uh oh!

jsafrane commented Apr 10, 2019

Uh oh!

jsafrane commented Apr 10, 2019

Uh oh!

jsafrane commented Apr 15, 2019

Uh oh!

jsafrane commented Apr 15, 2019

Uh oh!

bertinatto commented Apr 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mfojtik Apr 18, 2019

Choose a reason for hiding this comment

Uh oh!

mfojtik commented Apr 18, 2019

Uh oh!

smarterclayton commented Apr 18, 2019

Uh oh!

smarterclayton commented Apr 18, 2019

Uh oh!

openshift-ci-robot commented May 12, 2019

Uh oh!

openshift-ci-robot commented May 28, 2019

Uh oh!

openshift-ci-robot commented May 28, 2019

Uh oh!

jsafrane commented May 28, 2019

Uh oh!

jsafrane commented May 28, 2019

Uh oh!

openshift-ci-robot commented May 28, 2019

Uh oh!

jsafrane commented May 28, 2019

Uh oh!

openshift-ci-robot commented May 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jsafrane commented Apr 3, 2019 •

edited

Loading

bertinatto commented Apr 17, 2019 •

edited

Loading