Support --from-image-stream-file on release new for archival purposes #22438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
Author
|
/retest |
It should be possible to snapshot a release stream with `oc get is ... -o yaml` and then build a release from it later for archival and historical backup. Support providing an image stream file instead of requiring a live lookup. Refactor the reference loading code to allow spec tags with image IDs to not require a successful import recorded in status, and specifically error when we encounter that condition.
smarterclayton
force-pushed
the
add_image_stream_file
branch
from
7f2aae8 to
9759545
Compare
Contributor
Author
|
#22439 will include this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to snapshot a release stream with
oc get is ... -o yamland then build a release from it later forarchival and historical backup. Support providing an image stream file
instead of requiring a live lookup.
Refactor the reference loading code to allow spec tags with image IDs
to not require a successful import recorded in status, and specifically
error when we encounter that condition.