Skip to content

customresourcevalidation: switch Features to FeatureGate #22389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Mar 23, 2019
Merged

customresourcevalidation: switch Features to FeatureGate #22389

openshift-merge-robot merged 3 commits into from
Mar 23, 2019

Conversation

@sjenning
Copy link
Contributor

@sjenning sjenning commented Mar 21, 2019

@sjenning sjenning requested a review from adambkaplan March 21, 2019 19:35
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 21, 2019
@sjenning sjenning mentioned this pull request Mar 21, 2019
Merged
@adambkaplan adambkaplan mentioned this pull request Mar 21, 2019
Closed
adambkaplan
adambkaplan requested changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjenning small nits, otherwise lgtm

pkg/admission/customresourcevalidation/features/validate_features.go Outdated
}

func toFeatureV1(uncastObj runtime.Object) (*configv1.Features, field.ErrorList) {
func toFeatureV1(uncastObj runtime.Object) (*configv1.FeatureGate, field.ErrorList) {
Copy link
Contributor

@adambkaplan adambkaplan Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: /s/toFeatureV1/toFeatureGateV1/

pkg/admission/customresourcevalidation/features/validate_features.go Outdated
var knownFeatureSets = sets.NewString("", string(configv1.TechPreviewNoUpgrade))

func validateFeatureSpecCreate(spec configv1.FeaturesSpec) field.ErrorList {
func validateFeatureSpecCreate(spec configv1.FeatureGateSpec) field.ErrorList {
Copy link
Contributor

@adambkaplan adambkaplan Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename to validateFeatureGateSpecCreate

pkg/admission/customresourcevalidation/features/validate_features.go Outdated
}

func validateFeatureSpecUpdate(spec, oldSpec configv1.FeaturesSpec) field.ErrorList {
func validateFeatureSpecUpdate(spec, oldSpec configv1.FeatureGateSpec) field.ErrorList {
Copy link
Contributor

@adambkaplan adambkaplan Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename to validateFeatureGateSpecUpdate

@adambkaplan
Copy link
Contributor

adambkaplan commented Mar 21, 2019

@sjenning I also had to run make update to pull in changes to openapi

@sjenning
Copy link
Contributor Author

sjenning commented Mar 21, 2019

@adambkaplan ok I think I got everything

adambkaplan
adambkaplan approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes, build api update, and s2i bump lgtm.

@rphillips
Copy link
Contributor

rphillips commented Mar 21, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adambkaplan adambkaplan mentioned this pull request Mar 21, 2019
Merged
@sjenning
Copy link
Contributor Author

sjenning commented Mar 22, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@rphillips
Copy link
Contributor

rphillips commented Mar 22, 2019

/retest

@sjenning
Copy link
Contributor Author

sjenning commented Mar 22, 2019

/refresh

@sjenning
Copy link
Contributor Author

sjenning commented Mar 22, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@rphillips
Copy link
Contributor

rphillips commented Mar 23, 2019

/test e2e-aws-image-ecosystem

@rphillips
Copy link
Contributor

rphillips commented Mar 23, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4bc0236 into openshift:master Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@bparees bparees Awaiting requested review from bparees

Assignees

@rphillips rphillips

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sjenning @adambkaplan @rphillips @openshift-ci-robot @openshift-bot @openshift-merge-robot