Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Mar 20, 2019

awscli will allow us to add CI for user-provided infrastructure, as documented by openshift/installer@39a926a918 (openshift/installer#1408).

jq will allow us to simplify the templating which landed in openshift/release@7e56379d0b (openshift/release#2633).

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 20, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor

I don't think awscli belongs. We'd have to add gcloud, azure cli, etc. CI tooling like that should be in a separate container within the installer pod. We don't ship those as RPMs in downstream either and can't keep pace.

@smarterclayton
Copy link
Contributor

jq is in the same boat.

jq will allow us to simplify the templating which landed in
openshift/release@7e56379d0b (templates/openshift: grab bootstrap log
on failure, 2019-01-14, openshift/release#2633).
@wking
Copy link
Member Author

wking commented Mar 22, 2019

I don't think awscli belongs.

Yeah, @abhinavdahiya was suggesting that I do something like what we currently do for the nested libvirt installer. That makes sense, so I've dropped awscli here with a01f245 -> 2cf1197.

jq is in the same boat.

Why is this? The teardown container uses the tests image since openshift/release#2911 to get gzip for compressing retrieved logs. That's independent of installation. Similarly, jq is for extracting the bootstrap IP in the for slurping its journald (commit linked in my topic post here). I'm fine putting platform-specific, UPI-launching tools in new, platform-specific, CI-only installer images, but it seems like generic cluster-querying tooling like jq should go in this image.

@wking wking changed the title images/tests/Dockerfile.rhel: Install awscli and jq images/tests/Dockerfile.rhel: Install jq Mar 22, 2019
@openshift-ci-robot
Copy link

@wking: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2019
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2019
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 8, 2019
@openshift-ci-robot
Copy link

@wking: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/images 2cf1197 link /test images
ci/prow/e2e-aws 2cf1197 link /test e2e-aws
ci/prow/e2e-aws-serial 2cf1197 link /test e2e-aws-serial
ci/prow/cmd 2cf1197 link /test cmd
ci/prow/images-artifacts 2cf1197 link /test images-artifacts

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants