Skip to content

pkg/oc/cli/admin/release/new: Always include kube-etcd-signer-server #22325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wking wants to merge 1 commit into from
Closed

pkg/oc/cli/admin/release/new: Always include kube-etcd-signer-server #22325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/oc/cli/admin/release/new.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func NewNewOptions(streams genericclioptions.IOStreams) *NewOptions {
// TODO: only cluster-version-operator and maybe CLI should be in this list,
// the others should always be referenced by the cluster-bootstrap or
// another operator.
Copy link
Contributor

@hexfusion hexfusion Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the signer server lives in the bootstrap node and dies with it I believe. How does this work it just makes sure the image is always available? The TODO seems to say other stuff shouldn't be here just trying to understand workflow.

AlwaysInclude: []string{"cluster-version-operator", "cli", "installer"},
AlwaysInclude: []string{"cluster-version-operator", "cli", "installer", "kube-etcd-signer-server"},
ToImageBaseTag: "cluster-version-operator",
// We strongly control the set of allowed component versions to prevent confusion
// about what component versions may be used for. Changing this list requires
Expand Down