Skip to content

Add stub for console config validation #22103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 22, 2019
Merged

Add stub for console config validation #22103

openshift-merge-robot merged 1 commit into from
Feb 22, 2019

Conversation

@benjaminapetersen
Copy link
Contributor

@benjaminapetersen benjaminapetersen commented Feb 20, 2019 •
edited
Loading

@spadgett @enj fyi

This is just a stub, but should get us parsing & a single config named cluster. That's a win, we can follow with additional validation.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 20, 2019
@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Feb 20, 2019

/assign @deads2k

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Feb 20, 2019

/cc @openshift/sig-master

enj
enj previously requested changes Feb 20, 2019
View reviewed changes
@benjaminapetersen benjaminapetersen force-pushed the console/console-config-validation branch from 6e79de5 to d1ddacd Compare February 20, 2019 16:47
@enj
Copy link
Contributor

enj commented Feb 20, 2019

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2019
deads2k
deads2k reviewed Feb 20, 2019
View reviewed changes
@deads2k
Copy link
Contributor

deads2k commented Feb 20, 2019

/approve
/hold

holding to fix the create versus update. feel free to unhold after

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 20, 2019
@benjaminapetersen benjaminapetersen force-pushed the console/console-config-validation branch from d1ddacd to afd9f65 Compare February 20, 2019 18:55
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2019
@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Feb 20, 2019

Updated. @deads2k @enj, happy to get a quick glance to unhold/lgtm by anyone. Thx!

@enj
Copy link
Contributor

enj commented Feb 20, 2019

/lgtm
/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 20, 2019
@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Feb 20, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Feb 21, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@benjaminapetersen benjaminapetersen force-pushed the console/console-config-validation branch from afd9f65 to 52eeef4 Compare February 21, 2019 15:03
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Feb 21, 2019

rebased (conflicts w/#22102). @enj care to re-lgtm?

@enj
Copy link
Contributor

enj commented Feb 21, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@benjaminapetersen benjaminapetersen force-pushed the console/console-config-validation branch from 52eeef4 to 119e7f5 Compare February 21, 2019 20:09
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@enj
Copy link
Contributor

enj commented Feb 21, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, deads2k, enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4a4e950 into openshift:master Feb 22, 2019
@benjaminapetersen benjaminapetersen deleted the console/console-config-validation branch February 22, 2019 15:05
@benjaminapetersen benjaminapetersen mentioned this pull request Feb 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@mfojtik mfojtik Awaiting requested review from mfojtik

+1 more reviewer

@enj enj enj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@enj enj

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/master size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@benjaminapetersen @enj @deads2k @openshift-bot @openshift-ci-robot @openshift-merge-robot