Add git to the test image to ensure we can perform new-app tests #22065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
@smarterclayton: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
added a commit
to wking/origin
that referenced
this pull request
Feb 20, 2019
This image is primarily intended for running the test suite against an external cluster, but it's also a convenient place to collect the tools needed to retrieve and store logs extracted from those tested clusters. If the inspection dependencies become too onerous, we might want to split them out into their own image, but for now it seems easier to overload tests. It's not clear to me why only the RHEL Dockerfile lists util-linux, which it has since 228e3f5 (Add git to the test image to ensure we can perform new-app tests, 2019-02-17, openshift#22065), but I've left that part alone.
wking
reviewed
Feb 20, 2019
|
|
||
| FROM registry.svc.ci.openshift.org/ocp/4.0:cli | ||
| COPY --from=builder /go/src/github.com/openshift/origin/_output/local/bin/linux/amd64/openshift-tests /usr/bin/ | ||
| RUN yum install --setopt=tsflags=nodocs -y git util-linux && yum clean all && rm -rf /var/cache/yum/* |
Member
There was a problem hiding this comment.
Why util-linux? If you need it, shouldn't it be added to images/tests/Dockerfile too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.