Skip to content

Add openshift-integrated-oauth-server command #21987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 4 commits into from
Feb 28, 2019
Merged

Add openshift-integrated-oauth-server command #21987

openshift-merge-robot merged 4 commits into from
Feb 28, 2019

Conversation

@enj
Copy link
Contributor

@enj enj commented Feb 7, 2019

This serves as the official standalone binary run by the cluster-authentication-operator when it is managing the integrated OAuth server.

Signed-off-by: Monis Khan mkhan@redhat.com

@openshift/sig-auth

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 7, 2019
@enj enj force-pushed the enj/i/osin_server_binary branch from 875950f to 608832b Compare February 7, 2019 21:03
ericavonb
ericavonb reviewed Feb 7, 2019
View reviewed changes
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2019
@enj enj force-pushed the enj/i/osin_server_binary branch from 608832b to 986b040 Compare February 11, 2019 03:03
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2019
@enj
Copy link
Contributor Author

enj commented Feb 11, 2019

/hold

I will work on finishing this up after I get back.

@soltysh are the completion changes in 986b040 expected?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2019
soltysh
soltysh suggested changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also vendor/github.com/vmware/photon-controller-go-sdk is unexpected change

glide.lock
- name: github.com/spf13/cast
version: e31f36ffc91a2ba9ddb72a4b6a607ff9b3d3cb63
- name: github.com/spf13/cobra
version: c439c4fa093711d42e1b01acb1235b52004753c1
Copy link
Contributor

@soltysh soltysh Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't bump this, we need to use the same version as k8s is. That will be the reason for your unnecessary completion update.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2019
@enj enj force-pushed the enj/i/osin_server_binary branch from 986b040 to 29598aa Compare February 18, 2019 19:54
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 18, 2019
@enj
Copy link
Contributor Author

enj commented Feb 18, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2019
@enj
Copy link
Contributor Author

enj commented Feb 18, 2019

/retest

4 similar comments
@enj
Copy link
Contributor Author

enj commented Feb 19, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Feb 19, 2019

/retest

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 19, 2019

/retest

@stlaz
Copy link
Contributor

stlaz commented Feb 19, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Feb 19, 2019

Comments addressed and CI is green. Tagging. Approval is purely related to the OAuth server.

@enj enj added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 19, 2019
@stlaz
Copy link
Contributor

stlaz commented Feb 19, 2019 •
edited
Loading

I suspect we only need to keep the hypershift path so that the auth operator still functions. That's fine for now.

/lgtm

edit: apparently I was too late

@enj
Copy link
Contributor Author

enj commented Feb 20, 2019

/retest
/refresh
/skip

@enj
Copy link
Contributor Author

enj commented Feb 21, 2019

/retest
/refresh

@enj
Copy link
Contributor Author

enj commented Feb 21, 2019

/retest
/refresh
/skip

@enj enj mentioned this pull request Feb 21, 2019
Merged
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 21, 2019

New changes are detected. LGTM label has been removed.

@enj enj added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: enj, soltysh, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

enj added 4 commits February 21, 2019 21:32
@enj
Add openshift-integrated-oauth-server command
f6eb5db 
This serves as the official standalone binary run by the
cluster-authentication-operator when it is managing the integrated
OAuth server.

Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj
Add cmd/openshift-integrated-oauth-server as compile target
9b46cc9 
Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj
Update import restrictions for new command
728d018 
Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj
Wire loginURL to token request endpoint
60f2b51 
Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj enj removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@enj enj force-pushed the enj/i/osin_server_binary branch from 0794552 to 60f2b51 Compare February 22, 2019 02:35
@enj enj added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@enj
Copy link
Contributor Author

enj commented Feb 23, 2019

/retest

1 similar comment
@enj
Copy link
Contributor Author

enj commented Feb 25, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@enj
Copy link
Contributor Author

enj commented Feb 27, 2019

/test e2e-aws-serial
/test e2e-aws

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@enj
Copy link
Contributor Author

enj commented Feb 27, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Feb 27, 2019

/test e2e-aws

@enj
Copy link
Contributor Author

enj commented Feb 28, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Feb 28, 2019

/test e2e-aws-serial
/test e2e-aws

@enj
Copy link
Contributor Author

enj commented Feb 28, 2019

/test e2e-aws-serial

@enj
Copy link
Contributor Author

enj commented Feb 28, 2019

/retest
/refresh

@openshift-merge-robot openshift-merge-robot merged commit d4b6dbc into openshift:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ericavonb ericavonb ericavonb left review comments

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stlaz stlaz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@enj @smarterclayton @stlaz @openshift-ci-robot @openshift-bot @soltysh @ericavonb @openshift-merge-robot