Fix the router tests host name to use the external load balancer service #21799
Conversation
openshift-ci-robot
added
the
size/XS
ramr
force-pushed
the
fix-router-test-hostname
branch
from
25a4198 to
ef1ea64
Compare
ramr
force-pushed
the
fix-router-test-hostname
branch
from
ef1ea64 to
d4f3359
Compare
host name if it is available. On aws when the proxy protocol is enabled, the cluster ip would talk the "proxy" protocol, so we have to use the external load balancer host name to talk http[s].
ramr
force-pushed
the
fix-router-test-hostname
branch
from
d4f3359 to
9dec900
Compare
|
@ironcladlou updated - I just simplified the change to let the initial value be what it originally was and set to a valid hostname if the type is load balancer (it also waits for a value to be populated in) and tests all passed - PTAL and approve - the PROXY protocol PR is blocked behind this. Thx |
|
Thanks! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, ramr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Flake: |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 participants
host name if it is available.
On aws when the proxy protocol is enabled, the cluster ip would talk the
"proxy" protocol, so we have to use the external load balancer host name to
talk http[s].
This is blocking openshift/cluster-ingress-operator#84 tests.
@ironcladlou PTAL thx