Add default wildcard routing e2e test by ironcladlou · Pull Request #21617 · openshift/origin

ironcladlou · 2018-12-04T21:50:05Z

Add a test which exercises:

Wildcard DNS management
Route host defaulting
Default wildcard certificates

By:

Creating a reencrypt route using only defaults
Asserting the route is accessible over its public hostname

This test should only execute when wildcard DNS management is enabled as
indicated by the presence of an ingress domain on the cluster config resource.

ironcladlou · 2018-12-04T21:50:16Z

/hold

ironcladlou · 2018-12-04T21:50:25Z

/cc @openshift/sig-network-edge

ironcladlou · 2018-12-05T15:12:26Z

/retest

Miciah · 2018-12-05T23:14:47Z

test/extended/router/wildcard.go

+	cmd := fmt.Sprintf(`
+		set -e
+		for i in $(seq 1 %d); do
+			code=$( curl -k -s -o /dev/null -w '%%{http_code}\n' %q ) || rc=$?


I'd suggest adding -m 1 to the curl command to time out after 1 second. If you want a higher timeout value, or if you want to observe timeoutSeconds more strictly, you could add if [[ $SECONDS -gt %d ]]; then echo timed out; exit 1; fi to the loop.

ironcladlou · 2019-01-16T16:25:01Z

Okay, finally getting back to this, I made the test only execute if we detect that the default router is fronted by a LoadBalancer service. I'm not sure that's the best way to do detection going forward, but I think it works for now and we desperately need this coverage.

ironcladlou · 2019-01-16T21:50:50Z

/hold cancel

ironcladlou · 2019-01-16T23:42:43Z

/retest

ironcladlou · 2019-01-17T00:06:18Z

/retest

ironcladlou · 2019-01-17T01:05:05Z

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/21617/pull-ci-openshift-origin-master-e2e-gcp/2714

This should be skipping on GCE so something’s wrong either in my skip detection or in the operator

ironcladlou · 2019-01-17T15:13:53Z

/retest

ironcladlou · 2019-01-17T16:34:39Z

/retest

ironcladlou · 2019-01-17T22:59:07Z

/retest

ironcladlou · 2019-01-18T15:03:21Z

So close!

/retest

ironcladlou · 2019-01-18T19:02:24Z

/retest

ironcladlou · 2019-01-19T00:36:28Z

/retest

smarterclayton · 2019-01-21T14:58:30Z

/test e2e-aws

Add a test which exercises: * Wildcard DNS management * Route host defaulting * Default wildcard certificates By: * Creating a reencrypt route using only defaults * Asserting the route is accessible over its public hostname This test should only execute when wildcard DNS management is enabled as indicated by the presence of an ingress domain on the cluster config resource.

ironcladlou · 2019-01-28T15:25:25Z

/retest

ironcladlou · 2019-01-28T16:09:15Z

/retest

ironcladlou · 2019-01-28T16:13:22Z

@smarterclayton had to rebase, please re-tag

knobunc · 2019-01-28T16:15:28Z

/lgtm

openshift-ci-robot · 2019-01-28T16:15:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, knobunc, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [ironcladlou,knobunc,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ironcladlou · 2019-01-28T16:31:13Z

/retest

ironcladlou · 2019-01-28T18:11:50Z

/retest

ironcladlou · 2019-01-28T19:48:22Z

/test e2e-aws-builds

openshift-bot · 2019-01-29T02:29:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-01-29T06:32:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

ironcladlou · 2019-01-29T12:39:37Z

/test e2e-aws-builds

openshift-bot · 2019-01-29T14:39:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-01-29T16:39:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

ironcladlou · 2019-01-29T17:13:41Z

/retest

ironcladlou · 2019-01-29T20:30:03Z

/retest

ironcladlou · 2019-01-30T01:17:13Z

Well, tests passed and instead of merging tests kicked off again for some reason.

/retest

openshift-bot · 2019-01-30T02:44:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-01-30T04:45:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-01-30T05:06:02Z

@ironcladlou: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp	`c9b7bda`	link	`/test e2e-gcp`
ci/prow/e2e-gcp-builds	`c9b7bda`	link	`/test e2e-gcp-builds`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pravisankar · 2019-01-30T10:28:34Z

/test e2e-aws-builds

ironcladlou · 2019-01-30T13:59:47Z

What a ride!

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2018

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2018

openshift-ci-robot added the sig/network-edge label Dec 4, 2018

openshift-ci-robot requested review from dcbw and smarterclayton December 4, 2018 21:51

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2018

Miciah reviewed Dec 5, 2018

View reviewed changes

ironcladlou mentioned this pull request Dec 20, 2018

Optimize private zone discovery openshift/cluster-ingress-operator#93

Merged

ironcladlou force-pushed the wildcard-dns-test branch from c9b7bda to cf98f0a Compare January 16, 2019 16:16

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2019

ironcladlou force-pushed the wildcard-dns-test branch from cf98f0a to 315fff1 Compare January 16, 2019 16:17

ironcladlou force-pushed the wildcard-dns-test branch from 315fff1 to cb67344 Compare January 16, 2019 21:44

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2019

ironcladlou mentioned this pull request Jan 21, 2019

openshift-ingress: Change namespace and permissions openshift/cloud-credential-operator#16

Merged

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2019

ironcladlou force-pushed the wildcard-dns-test branch from cb67344 to 2467250 Compare January 28, 2019 14:30

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 28, 2019

openshift-ci-robot assigned knobunc Jan 28, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019

ironcladlou mentioned this pull request Jan 29, 2019

[release-3.10] Fix broken update handling of path-based routes #21901

Closed

openshift-merge-robot merged commit 25fd8c7 into openshift:master Jan 30, 2019

Conversation

ironcladlou commented Dec 4, 2018

Uh oh!

ironcladlou commented Dec 4, 2018

Uh oh!

ironcladlou commented Dec 4, 2018

Uh oh!

ironcladlou commented Dec 5, 2018

Uh oh!

Miciah Dec 5, 2018

Choose a reason for hiding this comment

Uh oh!

ironcladlou Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

ironcladlou commented Jan 16, 2019

Uh oh!

ironcladlou commented Jan 16, 2019

Uh oh!

ironcladlou commented Jan 16, 2019

Uh oh!

ironcladlou commented Jan 17, 2019

Uh oh!

ironcladlou commented Jan 17, 2019

Uh oh!

ironcladlou commented Jan 17, 2019

Uh oh!

ironcladlou commented Jan 17, 2019

Uh oh!

ironcladlou commented Jan 17, 2019

Uh oh!

ironcladlou commented Jan 18, 2019

Uh oh!

ironcladlou commented Jan 18, 2019

Uh oh!

ironcladlou commented Jan 19, 2019

Uh oh!

smarterclayton commented Jan 21, 2019

Uh oh!

ironcladlou commented Jan 28, 2019

Uh oh!

ironcladlou commented Jan 28, 2019

Uh oh!

ironcladlou commented Jan 28, 2019

Uh oh!

knobunc commented Jan 28, 2019

Uh oh!

openshift-ci-robot commented Jan 28, 2019

Uh oh!

ironcladlou commented Jan 28, 2019

Uh oh!

ironcladlou commented Jan 28, 2019

Uh oh!

ironcladlou commented Jan 28, 2019

Uh oh!

openshift-bot commented Jan 29, 2019

Uh oh!

openshift-bot commented Jan 29, 2019

Uh oh!

ironcladlou commented Jan 29, 2019

Uh oh!

openshift-bot commented Jan 29, 2019

Uh oh!

openshift-bot commented Jan 29, 2019

Uh oh!

ironcladlou commented Jan 29, 2019

Uh oh!

ironcladlou commented Jan 29, 2019

Uh oh!

ironcladlou commented Jan 30, 2019

Uh oh!

openshift-bot commented Jan 30, 2019

Uh oh!

openshift-bot commented Jan 30, 2019

Uh oh!

openshift-ci-robot commented Jan 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pravisankar commented Jan 30, 2019

Uh oh!

openshift-ci-robot commented Jan 30, 2019 •

edited

Loading