tests: Create a new test binary that can be used instead of extended.tests #21459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
smarterclayton
force-pushed
the
extended_binary
branch
2 times, most recently
from
854716c to
415a8b1
Compare
Contributor
Author
|
/retest |
smarterclayton
force-pushed
the
extended_binary
branch
2 times, most recently
from
b8387f2 to
566dd93
Compare
smarterclayton
force-pushed
the
extended_binary
branch
3 times, most recently
from
d9955b7 to
8bc3422
Compare
smarterclayton
force-pushed
the
extended_binary
branch
3 times, most recently
from
429f08e to
b2b60aa
Compare
Contributor
Author
|
/retest |
smarterclayton
force-pushed
the
extended_binary
branch
from
b2b60aa to
03c1d7a
Compare
Contributor
Author
|
/test e2e-aws |
smarterclayton
force-pushed
the
extended_binary
branch
2 times, most recently
from
55b712c to
aae61b9
Compare
Contributor
Author
|
/retest |
smarterclayton
force-pushed
the
extended_binary
branch
from
aae61b9 to
0fcf6ea
Compare
Contributor
Author
|
/retest |
smarterclayton
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
smarterclayton
force-pushed
the
extended_binary
branch
from
0fcf6ea to
74cdb9b
Compare
Contributor
Author
|
/retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
smarterclayton
force-pushed
the
extended_binary
branch
from
74cdb9b to
cf13746
Compare
|
New changes are detected. LGTM label has been removed. |
smarterclayton
force-pushed
the
extended_binary
branch
from
cf13746 to
3eaed9e
Compare
Contributor
Author
|
/retest |
smarterclayton
force-pushed
the
extended_binary
branch
from
3eaed9e to
0021513
Compare
…y-run This is fixed in 1.12 so the commit can safely be dropped.
There can be only `openshift-tests`.
…tests Executing e2e tests under ginkgo is hard to explain and use. Create a new top level command `openshift-tests` that focuses on four key improvements: 1. Focus on end user interaction - one command, a subcommand with help, and minimal arguments 2. Provide simpler and more concrete status update as tests are being run (ginkgo makes it too difficult to see what tests are running and progress) 3. Provide a better dry-run mode to see what tests are going to be executed 4. Replace the use of regexps with simple suites. Allow clever filtering using the --dry-run output for a suite and the `-f -` input to suite run. This command will be the primary interaction method for CI and end user test function. We will remove and deprecate all older suites as we go. This commit does not attempt to simplify suite assignment - that will be reserved for a future change.
smarterclayton
force-pushed
the
extended_binary
branch
from
0021513 to
5ff7aed
Compare
|
@smarterclayton: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
added a commit
to wking/origin
that referenced
this pull request
May 15, 2020
We've had these since 5ff7aed (tests: Create a new test binary that can be used instead of extended.tests, 2018-11-09, openshift#21459), but conditions like ClusterVersion Progressing=True and ClusterOperator Degraded=True are serious enough that we don't want to see them post-install. Make it fatal to see those surprises at all, instead of giving operators a pass during an arbitrary post-install recovery window.
wking
added a commit
to wking/origin
that referenced
this pull request
May 15, 2020
We've had these since 5ff7aed (tests: Create a new test binary that can be used instead of extended.tests, 2018-11-09, openshift#21459), but conditions like ClusterVersion Progressing=True and ClusterOperator Degraded=True are serious enough that we don't want to see them post-install. Make it fatal to see those surprises at all, instead of giving operators a pass during an arbitrary post-install recovery window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing e2e tests under ginkgo is hard to explain and use. Create a new top level command
openshift-teststhat focuses on four key improvements:-f -input to suite run.This command will be the primary interaction method for CI and end user test function. We will remove and deprecate all older suites as we go.
This commit does not attempt to simplify suite assignment - that will be reserved for a future change.
TODO: