Do not retry conflicts during storage migration #21437
Conversation
Storage migration is special in that all it needs to do is a no-op update to cause the API server to migrate the object to the preferred version. Thus if we encounter a conflict, we know that something updated the object and we no longer need to do anything. If the object needed migration, the API server has already migrated it. Signed-off-by: Monis Khan <mkhan@redhat.com>
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
|
/cherrypick release-3.11 |
|
@enj: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@enj: new pull request created: #21449 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Storage migration is special in that all it needs to do is a no-op
update to cause the API server to migrate the object to the
preferred version. Thus if we encounter a conflict, we know that
something updated the object and we no longer need to do anything.
If the object needed migration, the API server has already migrated
it.
Signed-off-by: Monis Khan mkhan@redhat.com