Fix extended tests to check router daemonsets created by the ingress operator #21292

ramr · 2018-10-17T22:14:03Z

Changes as per comments in openshift/installer#467
@abhinavdahiya PTAL thx

Updated reference to installer PR

ramr · 2018-10-17T22:43:17Z

/retest

ramr · 2018-10-18T01:44:49Z

/retest

ironcladlou · 2018-10-18T13:14:29Z

/retest

ironcladlou · 2018-10-18T15:19:03Z

/retest

ramr · 2018-10-18T20:39:08Z

/retest

…operator.

ironcladlou · 2018-10-19T13:49:23Z

/retest

ramr · 2018-10-21T05:09:38Z

/retest

pravisankar · 2018-10-21T17:19:24Z

/retest

ramr · 2018-10-22T18:42:29Z

/retest

ironcladlou · 2018-10-22T18:55:18Z

Not sure how the CI error is related yet:

FAILURE after 7.080s: test/extended/clusterup.sh:91: executing 'oc cluster up --base-dir=/tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup --tag=3ff93eb --loglevel=4 --loglevel=4 --server-loglevel=4 --tag=3ff93eb' expecting success: the command returned the wrong error code
Standard output from the command:
Getting a Docker client ...
Pulling all required images ...
Pulling container image quay.io/coreos/bootkube:v0.13.0 ...
Pulled 1/1 layers, 100% complete
Extracting
Image quay.io/coreos/bootkube:v0.13.0 successfully pulled
Pulling container image quay.io/coreos/etcd:v3.2.24 ...
Pulled 2/6 layers, 50% complete
Pulled 3/6 layers, 50% complete
Pulled 4/6 layers, 67% complete
Pulled 5/6 layers, 83% complete
Pulled 6/6 layers, 100% complete
Extracting
Image quay.io/coreos/etcd:v3.2.24 successfully pulled
Determining server IP ...
Checking for supported Docker version (=>1.22) ...
Checking if required ports are available ...
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/root-ca.key
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/root-ca.crt
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/kube-ca.key
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/kube-ca.crt
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/apiserver.key
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/apiserver.crt
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/service-account.key
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/service-account.pub
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/admin.key
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/admin.crt
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/aggregator-ca.crt
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/apiserver-proxy.key
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/apiserver-proxy.crt
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/etcd-peer-ca.crt
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/etcd-peer.key
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/etcd-peer.crt
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/etcd-server.key
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/etcd-server.crt
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/etcd-client-ca.crt
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/etcd-client.key
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/etcd-client.crt
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/auth/admin.kubeconfig
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/auth/kubeconfig
Writing asset: /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls/kubeconfig

Standard error from the command:
I1021 17:40:58.028011    1966 helper.go:168] Docker config file not found in "/home/origin/.docker/config.json", will pull without credentials
I1021 17:40:59.025496    1966 helper.go:168] Docker config file not found in "/home/origin/.docker/config.json", will pull without credentials
I1021 17:41:00.540950    1966 up.go:444] Cannot use the Docker host IP(): <nil>
I1021 17:41:00.557150    1966 run.go:177] Creating container named ""

<snip>

host config:
  pid mode: 
  user mode: 
  network mode: 
  volume binds:
    /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls:/asset-input:z
    /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets:/asset-output:z
    /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/config:/config-output:z
    /tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/config:/config-input:z

Error: operator render exited 1: Docker run error rc=1; caused by: Docker run error rc=1
Caused By:
  Error: Docker run error rc=1
  Details:
    Image: openshift/origin-cluster-kube-controller-manager-operator:3ff93eb
    Entrypoint: [cluster-kube-controller-manager-operator]
    Command: [render --asset-input-dir=/asset-input --asset-output-dir=/asset-output --config-output-file=/config-output/kube-controller-manager-config.yaml --config-override-file=/config-input/kube-controller-manager-config-overrides.yaml --manifest-image=openshift/origin-hyperkube:3ff93eb --manifest-config-host-path=/tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/config --manifest-config-file-name=kube-controller-manager-config.yaml --manifest-secrets-host-path=/tmp/tmp.flQEyQmRTJ/clusterup/noargs/openshift.local.clusterup/assets/tls]

ramr · 2018-10-22T19:58:42Z

rebased - if it fails again, I will try to remove/revert this checkin and test once tests complete. Not sure what's causing it. Thx

ramr · 2018-10-22T20:55:35Z

checking with the commit reverted.

ramr · 2018-10-22T21:28:13Z

same error - doesn't seem to be related to this change.

openshift-ci-robot · 2018-10-22T21:30:25Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ramr
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bparees

If they are not already assigned, you can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

test/extended/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ramr · 2018-10-24T18:13:30Z

/retest

ramr · 2018-10-25T18:11:39Z

/retest

ramr · 2018-10-25T18:11:58Z

@abhinavdahiya PR needs approval. PTAL thx

imcsk8 · 2018-10-25T21:01:56Z

test/extended/util/framework.go

 			return nil, "", err
 		}
+		ds, err := k8sappsclient.DaemonSets(ns).Get("router-default", metav1.GetOptions{})
+		if err == nil {


can error be nil and still have an empty DaemonSet?

No error means a valid DaemonSet.
Did you mean to ask for the case the DaemonSet doesn't exist and it would return nil here?
In that case, there'd be a daemonset not found error returned.

ramr · 2018-10-25T23:54:59Z

/retest

ramr · 2018-10-29T19:43:21Z

/retest

openshift-ci-robot · 2018-12-20T07:16:14Z

@ramr: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2018-12-21T05:51:47Z

@ramr: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_clusterup	`918efb9`	link	`/test extended_clusterup`
ci/prow/launch-aws	`918efb9`	link	`/test launch-aws`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ramr · 2018-12-22T03:12:45Z

Closing this out. Superseeded by and fixed in #21680

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2018

openshift-ci-robot requested review from ironcladlou and smarterclayton October 17, 2018 22:14

Fix extended tests to check router daemonsets created by the ingress …

918efb9

…operator.

ramr force-pushed the fix-router-check branch from 247b548 to 918efb9 Compare October 22, 2018 19:57

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2018

ramr force-pushed the fix-router-check branch from 47b6f1b to 918efb9 Compare October 22, 2018 21:29

openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2018

imcsk8 reviewed Oct 25, 2018

View reviewed changes

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2018

ramr closed this Dec 22, 2018

Fix extended tests to check router daemonsets created by the ingress operator #21292

Fix extended tests to check router daemonsets created by the ingress operator #21292

Uh oh!

Conversation

ramr commented Oct 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ramr commented Oct 17, 2018

Uh oh!

ramr commented Oct 18, 2018

Uh oh!

ironcladlou commented Oct 18, 2018

Uh oh!

ironcladlou commented Oct 18, 2018

Uh oh!

ramr commented Oct 18, 2018

Uh oh!

ironcladlou commented Oct 19, 2018

Uh oh!

ramr commented Oct 21, 2018

Uh oh!

pravisankar commented Oct 21, 2018

Uh oh!

ramr commented Oct 22, 2018

Uh oh!

ironcladlou commented Oct 22, 2018

Uh oh!

ramr commented Oct 22, 2018

Uh oh!

ramr commented Oct 22, 2018

Uh oh!

ramr commented Oct 22, 2018

Uh oh!

openshift-ci-robot commented Oct 22, 2018

Uh oh!

ramr commented Oct 24, 2018

Uh oh!

ramr commented Oct 25, 2018

Uh oh!

ramr commented Oct 25, 2018

Uh oh!

imcsk8 Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

ramr Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

ramr commented Oct 25, 2018

Uh oh!

ramr commented Oct 29, 2018

Uh oh!

openshift-ci-robot commented Dec 20, 2018

Uh oh!

openshift-ci-robot commented Dec 21, 2018

Uh oh!

ramr commented Dec 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ramr commented Oct 17, 2018 •

edited

Loading