Skip to content

Revert "use namespace labels to prevent SCC usage" #21232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 22, 2018
Merged

Revert "use namespace labels to prevent SCC usage" #21232

openshift-merge-robot merged 1 commit into from
Oct 22, 2018

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Oct 11, 2018

Reverts #21183

The openshift-apiserver can now be successfully installed by openshift/installer. Let's see how this goes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Oct 11, 2018

@smarterclayton @derekwaynecarr I'm not seeing an aws job listed in status. Did it not get turned on for origin?

@smarterclayton
Copy link
Contributor

smarterclayton commented Oct 12, 2018

No, was waiting for stability. I’ll turn it on tomorrow.

@deads2k
Copy link
Contributor Author

deads2k commented Oct 12, 2018

/hold

need to hold this until we get the aws job on origin.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Oct 12, 2018

@abhinavdahiya fyi

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Oct 12, 2018

@deads2k please don't make branches in origin, use your own fork

@deads2k
Copy link
Contributor Author

deads2k commented Oct 15, 2018

@abhinavdahiya is there an easy way to try this in the CI ahead of time. It should work fine

@deads2k
Copy link
Contributor Author

deads2k commented Oct 15, 2018

@deads2k please don't make branches in origin, use your own fork

sorry, didn't know that's what the button does.

/test all

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 15, 2018 •
edited
Loading

is there an easy way to try this in the CI ahead of time. It should work fine

hmm;
you can bring up cluster from head of installer; wait for cluster to be completely deployed.
then run this from this branch
make test-extended SUITE=core FOCUS="Secrets should be consumable from pods in volume with defaultMode set" TEST_EXTENDED_ARGS="-provider=aws -gce-zone=us-east-1 --v=6"

@deads2k
Copy link
Contributor Author

deads2k commented Oct 16, 2018

I see

• [SLOW TEST:23.250 seconds]
[sig-storage] Secrets
/home/deads/workspaces/openshift/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/common/secrets_volume.go:33
  should be consumable from pods in volume with defaultMode set [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
  /home/deads/workspaces/openshift/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:684
------------------------------
Oct 16 14:28:54.100: INFO: Running AfterSuite actions on all node


Oct 16 14:28:31.170: INFO: Running AfterSuite actions on all node
Oct 16 14:28:54.167: INFO: Running AfterSuite actions on node 1


Ran 1 of 1263 Specs in 23.456 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 1262 Skipped

@deads2k
Copy link
Contributor Author

deads2k commented Oct 16, 2018

/test all

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 16, 2018

I see

• [SLOW TEST:23.250 seconds]
[sig-storage] Secrets
/home/deads/workspaces/openshift/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/common/secrets_volume.go:33
  should be consumable from pods in volume with defaultMode set [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
  /home/deads/workspaces/openshift/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:684
------------------------------
Oct 16 14:28:54.100: INFO: Running AfterSuite actions on all node


Oct 16 14:28:31.170: INFO: Running AfterSuite actions on all node
Oct 16 14:28:54.167: INFO: Running AfterSuite actions on node 1


Ran 1 of 1263 Specs in 23.456 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 1262 Skipped

This seems correct.

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Oct 16, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Oct 16, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Oct 16, 2018

/test e2e-aws

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 16, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Oct 16, 2018

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 17, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 17, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 17, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 17, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 17, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 20, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

22 similar comments
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 20, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 20, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 20, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 20, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

vdemeester pushed a commit to vdemeester/origin that referenced this pull request Oct 22, 2018
@openshift-merge-robot
Merge pull request openshift#21232 from openshift/revert-21183-e2e-01…
1bd085b 
…-runlevel

Revert "use namespace labels to prevent SCC usage"
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2018

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-conformance-k8s 4107009 link /test e2e-conformance-k8s
ci/openshift-jenkins/extended_clusterup 4107009 link /test extended_clusterup

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4107009 into master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@squeed squeed Awaiting requested review from squeed

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@deads2k @openshift-ci-robot @smarterclayton @stevekuznetsov @abhinavdahiya @openshift-bot @openshift-merge-robot