Skip to content

Require Go 1.4 for OpenShift #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-bot merged 1 commit into from
May 19, 2015
Merged

Require Go 1.4 for OpenShift #2006

openshift-bot merged 1 commit into from
May 19, 2015

Conversation

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Apr 30, 2015

Cannot be merged until centos7 has Go 1.4 available as RPMs.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Apr 30, 2015

Covers #1070

ncdc
ncdc reviewed Apr 30, 2015
View reviewed changes
hack/common.sh
Copy link
Contributor

@ncdc ncdc Apr 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/requires/require/

@smarterclayton smarterclayton mentioned this pull request Apr 30, 2015
Closed
ncdc
ncdc reviewed Apr 30, 2015
View reviewed changes
hack/verify-gofmt.sh Outdated
Copy link
Contributor

@ncdc ncdc Apr 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to require 1.4, why keep 1.2 & 1.3 here?

Copy link
Contributor Author

@smarterclayton smarterclayton Apr 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because

Copy link
Contributor

@ncdc ncdc Apr 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course 😄

@sdodson
Copy link
Member

sdodson commented Apr 30, 2015

Mind bumping the rpm build requires in the same PR?
https://github.com/openshift/origin/blob/master/openshift.spec#L28

@nak3 nak3 mentioned this pull request May 9, 2015
Merged
@sdodson
Copy link
Member

sdodson commented May 18, 2015

Should be fine to merge this WRT to RHEL builds. I don't know for certain that golang-1.4 is available for Centos yet.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented May 18, 2015

I don't believe it is, yet.

@mfojtik
Copy link
Contributor

mfojtik commented May 18, 2015

@smarterclayton it is.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented May 18, 2015

[test]

@openshift-bot
Copy link
Contributor

openshift-bot commented May 18, 2015

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2254/)

@smarterclayton smarterclayton changed the title WIP - Require Go 1.4 for OpenShift Require Go 1.4 for OpenShift May 18, 2015
@smarterclayton
Copy link
Contributor Author

smarterclayton commented May 18, 2015

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented May 18, 2015

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2254/) (Image: devenv-fedora_1564)

@openshift-bot
Copy link
Contributor

openshift-bot commented May 18, 2015

Evaluated for origin up to 1728638

openshift-bot pushed a commit that referenced this pull request May 19, 2015
Merge pull request #2006 from smarterclayton/require_go_14
36e0132 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 36e0132 into openshift:master May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smarterclayton @sdodson @mfojtik @openshift-bot @ncdc