ignore wait4 errs in observe max-err-count #18992
Conversation
openshift-ci-robot
added
the
size/XS
juanvallejo
force-pushed
the
jvallejo/cli-observe-1
branch
from
6737f17 to
7011f02
Compare
pkg/oc/cli/cmd/observe/observe.go
Outdated
| } | ||
| m.WithLabelValues(append(labels, strconv.Itoa(statusCode))...).Observe(float64(duration / time.Millisecond)) | ||
|
|
||
| if err != nil && err.Error() == errNoChildProc { |
There was a problem hiding this comment.
I'd rather not hardcode the value like that. See if you can get some reasonable information from the error, when being cast to exec.ExitError. I think you should be able to get ProcessState.Sys which 'returns system-dependent exit information about the process. Convert it to the appropriate underlying type, such as syscall.WaitStatus on Unix, to access its contents. ' from there you should be able to get some system-wide constant.
There was a problem hiding this comment.
agree, this isn't a reasonable fix
juanvallejo
force-pushed
the
jvallejo/cli-observe-1
branch
from
7011f02 to
ff682d3
Compare
openshift-ci-robot
added
size/S
juanvallejo
force-pushed
the
jvallejo/cli-observe-1
branch
from
ff682d3 to
a3f8ff7
Compare
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
One nit and you're good to go.
pkg/oc/cli/cmd/observe/observe.go
Outdated
| m.WithLabelValues(append(labels, strconv.Itoa(statusCode))...).Observe(float64(duration / time.Millisecond)) | ||
|
|
||
| errno := errnoError(err) | ||
| if errno == syscall.ECHILD { |
There was a problem hiding this comment.
Since you've already created that method just:
if errnoError(err) == syscall.ECHILD {
...
juanvallejo
force-pushed
the
jvallejo/cli-observe-1
branch
from
a3f8ff7 to
f28463a
Compare
|
@soltysh thanks, comment addressed |
juanvallejo
force-pushed
the
jvallejo/cli-observe-1
branch
from
f28463a to
0e0ee60
Compare
pkg/oc/cli/cmd/observe/observe.go
Outdated
| } | ||
|
|
||
| func errnoError(err error) syscall.Errno { | ||
| if err == nil { |
There was a problem hiding this comment.
How about:
if se, ok := err.(*os.SyscallError); ok {
if errno, ok := se.Err.(syscall.Errno); ok {
return errno
}
}
return 0
juanvallejo
force-pushed
the
jvallejo/cli-observe-1
branch
from
0e0ee60 to
7565f7d
Compare
|
/test gcp |
1 similar comment
|
/test gcp |
|
@juanvallejo: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanvallejo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 18953, 18992). |
5 participants
Fixes #17743
These errors should not count against the --maximum-errors count
as the process has cleanly run and exited before wait4 syscall is made.
cc @smarterclayton @soltysh