UPSTREAM: 57422: Rework method of updating atomic-updated data volumes #18165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
requested review from
jsafrane,
rootfs,
screeley44 and
sjenning
openshift-ci-robot
added
the
size/L
openshift-merge-robot
added
the
vendor-update
This was referenced Jan 18, 2018
|
flake #17974 and yum mirror failure |
|
/assign |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelsmith, jsafrane The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 18129, 18152, 17403, 18020, 18165). |
openshift-merge-robot
added a commit
that referenced
this pull request
Jan 21, 2018
Automatic merge from submit-queue. [3.7] UPSTREAM: 57422: Rework method of updating atomic-updated data volumes See #18165 for background info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a backport of kubernetes/kubernetes#57422
This change affects the way that secret, configmap, downwardAPI and projected volumes (which all use the same underlying code) implement their data update functionality.
..datasymlink even when a data volume has no data so consumers can have simplified update watch logic.Which issue(s) this PR fixes
This addresses https://bugzilla.redhat.com/show_bug.cgi?id=1516569 and https://bugzilla.redhat.com/show_bug.cgi?id=1430322
Special notes for your reviewer:
Release note: