Skip to content

Conversation

@ramr
Copy link
Contributor

@ramr ramr commented Apr 20, 2015

Initial cut of the HA config implementation based on the proposal in #1730

Example usage:

#  label some nodes router=us-west-ha
openshift kube label node minion-1 "router=us-west-ha"  
openshift kube label node minion-2 "router=us-west-ha"  

#  create router and ha sidecar on the labelled nodes.  
openshift ex router --create --labels="router=us-west-ha" --credentials="${KUBECONFIG}" --replicas=2  
openshift ex ipfailover har --virtual-ips=10.0.2.100-102 --credentials=$KUBECONFIG  --replicas=2 -w 80 --latest-images --selector="router=us-west-ha" --create  

FYI, @smarterclayton @pweil- PTAL and let me know if this approach seems okay.

This PR is dependent on the proposal PR - so don't merge till #1730 is merged in.
So there's probably going to be duplicate cruft in here (the cleaned up version of the keepalived demo pieces).

Also there is more work to do to handle nodes joining/leaving the cluster and on their labels changing.

Edit: updated command name from haconfig to ipfailover

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to do a go echo server here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this was just to test and verify the image is okay before I had the integration code in place. The image verification test monitors the echo server listen port.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K, just noticed it while i was going through.

----- Original Message -----

@@ -0,0 +1,36 @@
+#!/usr/bin/env python
+

Yeah, this was just to test and verify the image is okay before I had the
integration code in place. The image verification test monitors the echo
server listen port.


Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1807/files#r28801451

@ramr ramr changed the title [DO NOT MERGE] HA config implementation based on proposal in PR 1730 HA config implementation based on proposal in PR 1730 Apr 21, 2015
@ramr
Copy link
Contributor Author

ramr commented Apr 22, 2015

made all fixes as per review comments (and rebased) @smarterclayton PTAL. Thx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need a service - or at least, I can't think of a reason you would need one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - will remove it.

@ramr ramr force-pushed the haconfig branch 2 times, most recently from 2e1b4a6 to 17d38d5 Compare April 26, 2015 07:01
@ramr
Copy link
Contributor Author

ramr commented Apr 27, 2015

@smarterclayton made fixes as per your review comments.

@smarterclayton
Copy link
Contributor

LGTM [merge] - we can track other items in later pulls. Thanks

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1686/) (Image: devenv-fedora_1370)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to de67a26

openshift-bot pushed a commit that referenced this pull request Apr 27, 2015
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 0327b30 into openshift:master Apr 27, 2015
@ramr ramr deleted the haconfig branch May 21, 2015 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants