-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HA config implementation based on proposal in PR 1730 #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to do a go echo server here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this was just to test and verify the image is okay before I had the integration code in place. The image verification test monitors the echo server listen port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K, just noticed it while i was going through.
----- Original Message -----
@@ -0,0 +1,36 @@
+#!/usr/bin/env python
+Yeah, this was just to test and verify the image is okay before I had the
integration code in place. The image verification test monitors the echo
server listen port.
Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1807/files#r28801451
|
made all fixes as per review comments (and rebased) @smarterclayton PTAL. Thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need a service - or at least, I can't think of a reason you would need one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok - will remove it.
Add HostNetwork capabilities. Add volume mount to container.
keepalived config generator.
Fixes and cleanup as per @smarterclayton review comments.
2e1b4a6 to
17d38d5
Compare
|
@smarterclayton made fixes as per your review comments. |
|
LGTM [merge] - we can track other items in later pulls. Thanks |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1686/) (Image: devenv-fedora_1370) |
|
Evaluated for origin up to de67a26 |
Merged by openshift-bot
Initial cut of the HA config implementation based on the proposal in #1730
Example usage:
FYI, @smarterclayton @pweil- PTAL and let me know if this approach seems okay.
This PR is dependent on the proposal PR - so don't merge till #1730 is merged in.
So there's probably going to be duplicate cruft in here (the cleaned up version of the keepalived demo pieces).
Also there is more work to do to handle nodes joining/leaving the cluster and on their labels changing.
Edit: updated command name from haconfig to ipfailover