Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rollout cancel and retry bugs #18022

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Fix rollout cancel and retry bugs #18022

merged 1 commit into from
Jan 10, 2018

Conversation

ironcladlou
Copy link
Contributor

Fix rollout cancel and retry command failures resulting from use of
internal types passed to strategic merge patch generation. Other CLI
commands already use an internal adapter to support this use case; the
deployment rollout commands are now in line with the existing wrapper
usages.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530750

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2018
@ironcladlou
Fix rollout cancel and retry bugs
6bfdc17 
Fix rollout cancel and retry command failures resulting from use of
internal types passed to strategic merge patch generation. Other CLI
commands already use an internal adapter to support this use case; the
deployment rollout commands are now in line with the existing wrapper
usages.
@ironcladlou
Copy link
Contributor Author

Unit test failure is an upstream panic in metrics registration, haven't found a flake reference yet. Rebasing and retrying.

E0108 22:11:04.151214   18977 runtime.go:66] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:72
/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:65
/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51
/usr/local/go/src/runtime/asm_amd64.s:509
/usr/local/go/src/runtime/panic.go:491
/usr/local/go/src/runtime/panic.go:63
/usr/local/go/src/runtime/signal_unix.go:367
github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/util/metrics/_test/_obj_test/util.go:70
/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134
/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88
/usr/local/go/src/runtime/asm_amd64.s:2337
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x7d0eef]
goroutine 6 [running]:
github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
        /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:58 +0x16f
panic(0x8252c0, 0xa7c8f0)
        /usr/local/go/src/runtime/panic.go:491 +0x2a2
github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/util/metrics.RegisterMetricAndTrackRateLimiterUsage.func1()
        github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/util/metrics/_test/_obj_test/util.go:70 +0x13f
github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1(0xc420010210)
        /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133 +0x70
github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc420010210, 0x12a05f200, 0x0, 0x45d101, 0xc42001e2a0)
        /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134 +0xce
github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.Until(0xc420010210, 0x12a05f200, 0xc42001e2a0)
        /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88 +0x5b
created by github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/util/metrics.RegisterMetricAndTrackRateLimiterUsage
        github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/util/metrics/_test/_obj_test/util.go:66 +0x1d5
FAIL    github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/util/metrics   0.030s

soltysh
soltysh approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 9, 2018
@ironcladlou
Copy link
Contributor Author

ironcladlou commented Jan 9, 2018 •
edited
Loading

Two flakes:

@ironcladlou
Copy link
Contributor Author

/test cmd

@ironcladlou
Copy link
Contributor Author

/test unit

@ironcladlou
Copy link
Contributor Author

/test extended_conformance_gce

@mfojtik
Copy link
Contributor

mfojtik commented Jan 9, 2018

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor

soltysh commented Jan 10, 2018 via email

@ironcladlou
Copy link
Contributor Author

/retest

1 similar comment
@ironcladlou
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17914, 18021, 18022, 17862, 18043).

@openshift-merge-robot openshift-merge-robot merged commit 187eaa6 into openshift:master Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

Assignees

@mfojtik mfojtik

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ironcladlou @mfojtik @openshift-ci-robot @soltysh @openshift-merge-robot