Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable router metrics test #17753

Merged
merged 1 commit into from
Dec 16, 2017
Merged

re-enable router metrics test #17753

merged 1 commit into from
Dec 16, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 13, 2017

fixes #17752

Add debugging for now

@deads2k deads2k mentioned this pull request Dec 13, 2017
Merged
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 13, 2017
@deads2k deads2k mentioned this pull request Dec 13, 2017
Closed
@smarterclayton
Copy link
Contributor

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/17753/test_pull_request_origin_extended_conformance_install/4041/artifacts/scripts/conformance/logs/containers/k8s_router_router-1-stk98_default_7f92075f-e03f-11e7-a41a-0e753ff7b6ac_0.log nothing in there useful. him

deads2k
deads2k commented Dec 13, 2017
View reviewed changes
pkg/router/metrics/metrics.go Outdated
@@ -99,10 +104,13 @@ func (l Listener) authorizeHandler(protected http.Handler) http.Handler {
scopedRecord.User = user
authorized, reason, err := l.Authorizer.Authorize(scopedRecord)
if authorized != authorizer.DecisionAllow || err != nil {
fmt.Printf("#### 1f\n")
if !ok || errors.IsUnauthorized(err) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking unauthorized on this error isn't correct since you get that when the router can't issue a SAR.

ok is the wrong ok post-rebase. I'll fix that up. Once I fix those two up, this should be ok.

@deads2k
Copy link
Contributor Author

deads2k commented Dec 13, 2017

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/17753/test_pull_request_origin_extended_conformance_install/4041/artifacts/scripts/conformance/logs/containers/k8s_router_router-1-stk98_default_7f92075f-e03f-11e7-a41a-0e753ff7b6ac_0.log nothing in there useful. him

I think I found it. I'll fix up the pull tomorrow.

@deads2k deads2k force-pushed the rebase-03-routermetrics branch from de921c0 to 905f605 Compare December 14, 2017 12:53
@deads2k
Copy link
Contributor Author

deads2k commented Dec 14, 2017

#17769

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 14, 2017

Test passed.

/assign @smarterclayton
/assign @enj

@deads2k deads2k force-pushed the rebase-03-routermetrics branch from 905f605 to 02c5991 Compare December 14, 2017 15:07
@enj
Copy link
Contributor

enj commented Dec 14, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, enj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Dec 14, 2017

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2017
@deads2k deads2k force-pushed the rebase-03-routermetrics branch from 02c5991 to f6b0568 Compare December 15, 2017 20:43
@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 15, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16281, 17293, 17717, 17753, 17830).

@openshift-merge-robot openshift-merge-robot merged commit 34bf9c9 into openshift:master Dec 16, 2017
@deads2k deads2k deleted the rebase-03-routermetrics branch January 24, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravisankar pravisankar Awaiting requested review from pravisankar

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/post-rebase lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

re-enable router tests
5 participants
@deads2k @smarterclayton @enj @openshift-ci-robot @openshift-merge-robot