-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase 1.9.0 beta.1 #17576
rebase 1.9.0 beta.1 #17576
Changes from 1 commit
f0bb2b6
c671103
07c6b99
710998e
c8626b7
f3769c7
123246b
534c679
ca1b85f
9ff7f3f
d34b354
df449cc
f046a0b
3c7a135
3f45cdc
ee0f726
de36874
64974bc
bf64f2c
cf235c2
4bc612e
66d94ff
fc9b4e2
5b3859b
d1b5fe8
42a1e2c
d49083e
07e5313
ab033d4
32a0c9a
27ad23a
f490d38
2f11419
b3fa18d
22f0b91
0aedd29
7f86e08
99c59c6
afdcb87
2abedd5
5d40a0f
4383cd7
7ffc267
244afd3
30fe89a
de21f14
80cef2d
a92560d
a1cef1f
8454d7d
9344e48
062ffb1
93bd84a
0089bbb
ad7d2fc
60d3fa9
b15c3b6
1d18e82
31f33b0
2cf15a3
ee8266b
bb2ecf0
2db374f
a4d2794
ebc468c
7256949
6c58566
d4ee63c
9e3ca9a
6b39f30
2fa3a79
d826d91
a783419
5c42201
b80c0d2
088b81d
cdc12ca
b374cbd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,10 +6,13 @@ import ( | |
|
||
"github.com/golang/glog" | ||
"github.com/spf13/cobra" | ||
"k8s.io/kubernetes/pkg/api/legacyscheme" | ||
|
||
apiextensioninstall "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/install" | ||
"k8s.io/apimachinery/pkg/api/meta" | ||
"k8s.io/apimachinery/pkg/runtime/schema" | ||
"k8s.io/apimachinery/pkg/util/sets" | ||
apiregistrationinstall "k8s.io/kube-aggregator/pkg/apis/apiregistration/install" | ||
"k8s.io/kubernetes/pkg/kubectl/cmd/templates" | ||
kcmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util" | ||
"k8s.io/kubernetes/pkg/kubectl/resource" | ||
|
@@ -161,6 +164,9 @@ func NewCmdMigrateAPIStorage(name, fullName string, f *clientcmd.Factory, in io. | |
Long: internalMigrateStorageLong, | ||
Example: fmt.Sprintf(internalMigrateStorageExample, fullName), | ||
Run: func(cmd *cobra.Command, args []string) { | ||
apiextensioninstall.Install(legacyscheme.GroupFactoryRegistry, legacyscheme.Registry, legacyscheme.Scheme) | ||
apiregistrationinstall.Install(legacyscheme.GroupFactoryRegistry, legacyscheme.Registry, legacyscheme.Scheme) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. need a follow up to figure out what we need to do to revert this... migrate shouldn't need registered types... it reads into unstructured and puts back There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
done |
||
|
||
kcmdutil.CheckErr(options.Complete(f, cmd, args)) | ||
kcmdutil.CheckErr(options.Validate()) | ||
kcmdutil.CheckErr(options.Run()) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brute force. Wondering how kubectl is importing the internal types right now (not everything is ported to versioned types). Looks like there is no single point where everything is imported (anymore).