Switch to openshift/api #17477
Switch to openshift/api #17477
Conversation
openshift-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
approved
deads2k
force-pushed
the
api-12-api
branch
6 times, most recently
from
69b85b9 to
9d70924
Compare
|
@liggitt This is actually pretty close. I'm chasing a failure in test/cmd/image, but that's the last one I know of. |
|
Oh, and we'll fix the proto definition stuff later. No idea why it dropped out. |
|
/test extended_builds |
|
@mfojtik I'm likely to get this ready tomorrow am. ptal |
|
@deads2k i'm going to try to chase the cmd failure till you get in. |
| @@ -1,4 +1,2 @@ | |||
| // +k8s:deepcopy-gen=package,register | |||
There was a problem hiding this comment.
why you dropped this?
it is generated in openshift/api.
| // +k8s:defaulter-gen=TypeMeta | ||
| // +k8s:openapi-gen=true | ||
| // +k8s:defaulter-gen-input=../../../../../../../../github.com/openshift/api/network/v1 |
There was a problem hiding this comment.
this is pretty ugly... can we improve the generator?
There was a problem hiding this comment.
this is pretty ugly... can we improve the generator?
Yeah. This one in particular is off. Once we break the back of the problem we can fine tune.
|
Can't repro this locally with this PR rebased against master, so I guess you just need a rebase and we are good to go. /retest |
|
@deads2k seems like |
Yeah. Also done in openshift/api |
|
Got an lgtm via irc. tagging and bumping priority. |
deads2k
added
lgtm
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
all blocking CI jobs were green on the PR HEAD commit |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Starts vendoring github.com/openshift/api instead of using the native types. I haven't updated unit tests yet, but I could use some CI runs to chase problems.