Skip to content

Conversation

@miminar
Copy link

@miminar miminar commented Oct 13, 2017

To preserve it for post-CI-job-debugging.

Follow-up for #15807
Addresses comment #15807 (comment)

To preserve it for post-CI-job-debugging.

Signed-off-by: Michal Minář <[email protected]>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2017
@miminar
Copy link
Author

miminar commented Oct 13, 2017

@bparees PTAL

@miminar
Copy link
Author

miminar commented Oct 13, 2017

/test extended_image_registry

@0xmichalis
Copy link
Contributor

/assign bparees
/unassign knobunc kargakis

path, err := oc.Run("logs").Args("dc/docker-registry").OutputToFile("pod-" + pod.Name + ".log")

ocLocal := *oc
ocLocal.SetOutputDir(exutil.ArtifactDirPath())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe exutil.ArtifactDirPath() returns a root dir for the artifacts - the one you can see in this view: https://ci.openshift.redhat.com/jenkins/view/Origin%20Test%20Jobs/job/test_branch_origin_extended_builds/238/s3/

I can see the artifacts dir in the view of prow runs: https://gcsweb-ci.svc.ci.openshift.org/gcs/origin-ci-test/pr-logs/pull/16859/test_pull_request_origin_extended_image_registry/36/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i was thinking it was the testadata fixture path, i guess i'm wrong.

@bparees
Copy link
Contributor

bparees commented Oct 13, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, miminar

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit b22e1ff into openshift:master Oct 15, 2017
@miminar miminar deleted the log-registry-pod-to-artifacts branch November 8, 2017 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants