Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdn: only sync HostPorts when we need to (backport to stage) #16814

Merged

Conversation

knobunc
Copy link
Contributor

@knobunc knobunc commented Oct 11, 2017

Backport of #16692 to stage branch

sdn: only sync HostPorts when we need to

Which is the first time a pod is started, when there will be active hostports, or when there are current active hostports. Otherwise the syncer runs iptables-restore for no good reason.

@openshift/networking @knobunc @danwinship

Automatic merge from submit-queue (batch tested with PRs 16741, 16692).

sdn: only sync HostPorts when we need to

Which is the first time a pod is started, when there will be active hostports, or when there are current active hostports.  Otherwise the syncer runs iptables-restore for no good reason.

@openshift/networking @knobunc @danwinship
@knobunc knobunc self-assigned this Oct 11, 2017
@knobunc knobunc requested a review from danwinship October 11, 2017 20:15
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2017
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 11, 2017
@knobunc knobunc requested a review from eparis October 11, 2017 20:15
@knobunc
Copy link
Contributor Author

knobunc commented Oct 11, 2017

/test

@knobunc knobunc changed the title Merge pull request #16692 from dcbw/sdn-sync-hostports-less sdn: only sync HostPorts when we need to (backport to stage) Oct 11, 2017
@eparis
Copy link
Member

eparis commented Oct 11, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, knobunc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@eparis
Copy link
Member

eparis commented Oct 11, 2017

/retest

@imcsk8
Copy link
Contributor

imcsk8 commented Oct 12, 2017

LGTM

@eparis
Copy link
Member

eparis commented Oct 12, 2017

/retest

@eparis eparis merged commit 0551026 into openshift:stage Oct 12, 2017
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 12, 2017

@knobunc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/end_to_end b5abfaf link /test end_to_end

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knobunc knobunc deleted the pick/pr16692-dont-iptables-when-no-hostport branch June 7, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/critical-fix size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants