Skip to content

extended: do not run suites if FOCUS is given #16806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miminar wants to merge 1 commit into from
Closed

extended: do not run suites if FOCUS is given #16806

miminar wants to merge 1 commit into from

Conversation

@miminar
Copy link

@miminar miminar commented Oct 11, 2017

Also make sure not to run serial tests that have been run among parallel ones already.

Do not use -suite when FOCUS is given.

extended: do not run suites if FOCUS is given
f5f604c 
Also make sure not to run serial tests that have been run among parallel
ones already.

Signed-off-by: Michal Minář <[email protected]>
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 11, 2017
@miminar
Copy link
Author

miminar commented Oct 11, 2017

Note that the following will fail because #15807 is still not merged:

/test extended_image_registry

@miminar
Copy link
Author

miminar commented Oct 11, 2017

/test

@miminar miminar mentioned this pull request Oct 11, 2017
Merged
@miminar
Copy link
Author

miminar commented Oct 11, 2017

/assign @stevekuznetsov
/cc @bparees

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 11, 2017 •
edited
Loading

@miminar: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd f5f604c link /test cmd
ci/openshift-jenkins/extended_image_registry f5f604c link /test extended_image_registry

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bparees
Copy link
Contributor

bparees commented Oct 11, 2017

/unassign @danwinship @jim-minter
/assign @smarterclayton

lgtm but needs review by the keepers of the extended test framework execution logic.

@bparees
Copy link
Contributor

bparees commented Oct 11, 2017

/approve

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 11, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, miminar

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2017
@smarterclayton smarterclayton added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2017
@smarterclayton
Copy link
Contributor

smarterclayton commented Oct 11, 2017

This is really complex, not sure I want this much code to solve this problem.

@smarterclayton
Copy link
Contributor

smarterclayton commented Oct 11, 2017

Putting it on hold until i have chance to look more

@miminar miminar mentioned this pull request Oct 12, 2017
Merged
This was referenced Oct 12, 2017
Closed
Closed
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2017
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 19, 2017

@miminar PR needs rebase

@miminar
Copy link
Author

miminar commented Oct 19, 2017

Obsoleted by #16919

@miminar miminar closed this Oct 19, 2017
@miminar miminar deleted the registry-extended-test-fixes-fixed-FOCUS branch February 22, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

Assignees

@smarterclayton smarterclayton

@stevekuznetsov stevekuznetsov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@miminar @openshift-ci-robot @bparees @openshift-merge-robot @smarterclayton @danwinship @jim-minter @stevekuznetsov