switch build logs to use client, not storage #16705
Conversation
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
pkg/build/registry/rest.go
Outdated
| _, err = watch.Until(timeout, w, func(event watch.Event) (bool, error) { | ||
| obj, ok := event.Object.(*buildapi.Build) | ||
| if !ok { | ||
| return false, fmt.Errorf("received unknown object while watching for builds: %T", obj) |
There was a problem hiding this comment.
@bparees just in case this doesn't resolve the problem.
There was a problem hiding this comment.
does obj actually get assigned if the type assertion fails?
deads2k
force-pushed
the
build-06-client
branch
from
88b1736 to
d0ed003
Compare
|
oh. you already did. |
|
/retest |
1 similar comment
|
/retest |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue. |
Automatic merge from submit-queue. switch build logs to use client, not storage fixes https://bugzilla.redhat.com/show_bug.cgi?id=1499016 stage pick of #16705 /assign bparees /assign jupierce did I get the right spot? What's the bugzilla number?
| } | ||
|
|
||
| return observed, true, nil |
There was a problem hiding this comment.
@deads2k @gabemontero if i'm reading this correctly, we now return "observed, true, nil" if we hit the timeout, whereas previously we returned "observed, false, nil".
and presumably if we hit a timeout, "observed" will be nil.
There was a problem hiding this comment.
(hm, maybe not, seems like watch.Until is supposed to be returning an error if it times out)
There was a problem hiding this comment.
ah, but we used to always return the input build if we timed out, now we return nil.
switches the build logs and build binary instantiate to use clients instead of RESTStorage.
/assign bparees
/king bug