One more fix to SDN controller perms #14979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
[test][testextended][extended:networking] |
Contributor
|
LGTM |
Contributor
|
[severity:blocker] |
Contributor
|
[merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 10 |
Contributor
|
Evaluated for origin merge up to c0f5e37 |
danwinship
force-pushed
the
more-wrong-policy-network
branch
from
c0f5e37 to
22bab43
Compare
Contributor
|
Evaluated for origin testextended up to 22bab43 |
Contributor
|
Evaluated for origin test up to 22bab43 |
Contributor
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/804/) (Base Commit: 1d1aa8a) (PR Branch Commit: 22bab43) (Extended Tests: networking) |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2884/) (Base Commit: 1d1aa8a) (PR Branch Commit: 22bab43) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #14968; the SDN controller also needs to be able to update HostSubnets.
Looking through pkg/sdn for Get/List/Create/Update/Delete calls, I'm pretty sure this now covers everything.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1466239
@openshift/networking @smarterclayton