clean up admin commands

[deads2k]

This properly segregate master cert generation from node cert generation. It eliminates unnecessary commands and starts properly passing command names and io.Writer

@liggitt

[smarterclayton]

Pass in fullName, name like the other cli commands

[deads2k]

Pass in fullName, name like the other cli commands

Done.

[smarterclayton]

Can you call them the same things the other ones do? fullName and name. And yes, the others are wrong if they're not like that.

[deads2k]

Seems like we'd want to pass name and baseName as opposed to name and fullName. Why would we want fullName instead?

[smarterclayton]

fullName is the name someone access you as in a larger context. Name is your name.

You are David. Your full name is David Eads.

----- Original Message -----

@@ -32,15 +33,15 @@ type CreateBootstrapPolicyFileOptions struct {
OpenShiftSharedResourcesNamespace string
}

-func NewCommandCreateBootstrapPolicyFile() *cobra.Command {
+func NewCommandCreateBootstrapPolicyFile(commandName string, baseName
string, out io.Writer) *cobra.Command {

Seems like we'd want to pass name and baseName as opposed to name and
fullName. Why would we want fullName instead?

---

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1454/files#r27217531

[deads2k]

And if you were passing information to an API, you wouldn't want to pass FullName, you'd pass FirstName LastName (or GivenName SurName).

Should args be: "create-master-certs", "openshift admin create-master-certs" or "create-master-certs", "openshift admin". I vote for the latter and some commands are taking that, but calling the second arg "fullName" in spite of it being a "baseName".

[smarterclayton]

On Mar 26, 2015, at 10:40 AM, David Eads [email protected] wrote:

In pkg/cmd/server/admin/create_bootstrappolicy_file.go:

@@ -32,15 +33,15 @@ type CreateBootstrapPolicyFileOptions struct {
OpenShiftSharedResourcesNamespace string
}

-func NewCommandCreateBootstrapPolicyFile() *cobra.Command {
+func NewCommandCreateBootstrapPolicyFile(commandName string, baseName string, out io.Writer) *cobra.Command {
And if you were passing information to an API, you wouldn't want to pass FullName, you'd pass FirstName LastName (or GivenName SurName).

Should args be: "create-master-certs", "openshift admin create-master-certs" or "create-master-certs", "openshift admin". I vote for the latter and some commands are taking that, but calling the second arg "fullName" in spite of it being a "baseName".

If you do that, every command has to do string manipulation. Stick to fullName name, but if you have a better naming scheme, do so.

—
Reply to this email directly or view it on GitHub.

[liggitt]

Add --create-certs=false to test-cmd, use commandName in create_commands.go, then LGTM

[liggitt]

I'll wait for this to go in on Monday before merging the https node PR

[deads2k]

@liggitt Comments seem to disappearing, but the create-node-config uses an https --listen because the server uses that by default and causes an all-in-one server without a specified config to expect to find node server certs. I think that splitting those parameters is outside the scope of what I'm trying to do here, so the https --listen will create the certs as expected, but still serve insecurely

[deads2k]

[merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1341/) (Image: devenv-fedora_1163)

[liggitt]

asset fix merged, re[merge]

[openshift-bot]

Evaluated for origin up to 28e7369