Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to use upstream remote authentication and authorization #14011

Merged
merged 2 commits into from
May 16, 2017
Merged

switch to use upstream remote authentication and authorization #14011

merged 2 commits into from
May 16, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented May 2, 2017

Switches our remove authentication and authorization to use the upstream versions so that we can remove duplicate code.

This is predicated on the notion that we do not support new kubelet and old apiserver. If we support that combination, we cannot do this.

@smarterclayton @liggitt

@deads2k
Copy link
Contributor Author

deads2k commented May 2, 2017

[test]

@smarterclayton
Copy link
Contributor

smarterclayton commented May 3, 2017 via email •
edited by enj
Loading

@deads2k
Copy link
Contributor Author

deads2k commented May 3, 2017

flake #12072

@deads2k
Copy link
Contributor Author

deads2k commented May 3, 2017

re[test]

@deads2k
Copy link
Contributor Author

deads2k commented May 3, 2017

provision again

re[test]

@sdodson
Copy link
Member

sdodson commented May 3, 2017

@sdodson FYI the 3.6 upgrade would now explicitly block 3.6 kubelet from running against any older server.

Ok, that shouldn't happen during any of our supported upgrade paths. We're always API/Controllers first.

When you say older you mean <= 1.5/3.5 or even within 1.6/3.6?

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2017
@deads2k deads2k force-pushed the auth-11-remote-upstream branch from e43b069 to 8d9e6e8 Compare May 8, 2017 13:26
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 8d9e6e8

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1229/) (Base Commit: 17ebd78)

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2017
@deads2k deads2k assigned enj and unassigned liggitt May 9, 2017
@deads2k
Copy link
Contributor Author

deads2k commented May 15, 2017

@enj let's get this tied off.

@enj
Copy link
Contributor

enj commented May 15, 2017

LGTM.

[merge]

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label May 15, 2017
@deads2k
Copy link
Contributor Author

deads2k commented May 16, 2017

[merge]

@enj
Copy link
Contributor

enj commented May 16, 2017

Flake #13980

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 8d9e6e8

@openshift-bot
Copy link
Contributor

openshift-bot commented May 16, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/660/) (Base Commit: b4244de) (Image: devenv-rhel7_6232)

@openshift-bot openshift-bot merged commit 38be652 into openshift:master May 16, 2017
@deads2k deads2k deleted the auth-11-remote-upstream branch August 3, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enj enj

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deads2k @smarterclayton @sdodson @openshift-bot @enj @liggitt