Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golang-1.7 to 1.7.5 #13803

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Conversation

fabianofranz
Copy link
Member

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1435261

Upgrades Go 1.7 from 1.7.4 to 1.7.5 to fix the TLS handshake timeout issue[1][2][3] seen by several users of macOS Sierra.

Basically the issue adds an overhead of ~3.5 seconds to the TLS handshake (more depending on the size of cert/key and networking conditions, like under VPN or proxy, we've seen it add around 6 seconds to the handshake). FYI our TLS handshake timeout is 10 seconds (Golang default and used by most tools).

There's a fix and it was backported[4] and is part of 1.7.5[5][6].

[1] golang/go#18688
[2] golang/go#18141
[3] golang/go#18203
[4] golang/go@5c2b5ee
[5] https://golang.org/doc/devel/release.html#go1.7.minor
[6] https://github.com/golang/go/issues?q=milestone%3AGo1.7.5

@smarterclayton @jwforres PTAL

@fabianofranz
Copy link
Member Author

[test]

@fabianofranz
Copy link
Member Author

We should probably consider backporting to 1.5.

@smarterclayton
Copy link
Contributor

You have to regenerate the fake RPM when you do this. And after you do this, yes backport.

@smarterclayton
Copy link
Contributor

Actually, no backport needed since these images are only built in master.

@fabianofranz
Copy link
Member Author

@smarterclayton done, PTAL

@stevekuznetsov
Copy link
Contributor

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to e2b5ee2

@smarterclayton
Copy link
Contributor

Lgtm [merge]

Can you also bump 1.8 to 1.8.1? :)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/794/) (Base Commit: cb35fa2)

@fabianofranz
Copy link
Member Author

flaked on #13271 re[merge]

@smarterclayton
Copy link
Contributor

smarterclayton commented Apr 20, 2017 via email

@fabianofranz
Copy link
Member Author

@smarterclayton 1.8.1 is in #13836

@smarterclayton
Copy link
Contributor

smarterclayton commented Apr 23, 2017 via email

@fabianofranz
Copy link
Member Author

[merge]

1 similar comment
@fabianofranz
Copy link
Member Author

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to e2b5ee2

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/463/) (Base Commit: 71f0a06) (Image: devenv-rhel7_6176)

@openshift-bot openshift-bot merged commit 39fc273 into openshift:master Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants