-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade golang-1.7 to 1.7.5 #13803
Upgrade golang-1.7 to 1.7.5 #13803
Conversation
[test] |
We should probably consider backporting to 1.5. |
You have to regenerate the fake RPM when you do this. And after you do this, yes backport. |
Actually, no backport needed since these images are only built in master. |
@smarterclayton done, PTAL |
We'll also need the newer Golang in https://cbs.centos.org/repos/paas7-openshift-origin36-candidate/x86_64/os/Packages/ /cc @tdawson |
Evaluated for origin test up to e2b5ee2 |
Lgtm [merge] Can you also bump 1.8 to 1.8.1? :) |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/794/) (Base Commit: cb35fa2) |
flaked on #13271 re[merge] |
[merge] flake on upgrade package lookup
…On Wed, Apr 19, 2017 at 10:13 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/390/)
(Base Commit: 846289d
<846289d>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13803 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p8vQQcQWSWhYS630e3qwTG1zrVfZks5rxr9RgaJpZM4NAn-X>
.
|
@smarterclayton 1.8.1 is in #13836 |
[merge]
…On Fri, Apr 21, 2017 at 4:13 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/412/)
(Base Commit: c106caf
<c106caf>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13803 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p79urtxnuZdMEvNFExl7gMBh7pHtks5ryQ3mgaJpZM4NAn-X>
.
|
[merge] |
1 similar comment
[merge] |
Evaluated for origin merge up to e2b5ee2 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/463/) (Base Commit: 71f0a06) (Image: devenv-rhel7_6176) |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1435261
Upgrades Go 1.7 from 1.7.4 to 1.7.5 to fix the TLS handshake timeout issue[1][2][3] seen by several users of macOS Sierra.
Basically the issue adds an overhead of ~3.5 seconds to the TLS handshake (more depending on the size of cert/key and networking conditions, like under VPN or proxy, we've seen it add around 6 seconds to the handshake). FYI our TLS handshake timeout is 10 seconds (Golang default and used by most tools).
There's a fix and it was backported[4] and is part of 1.7.5[5][6].
[1] golang/go#18688
[2] golang/go#18141
[3] golang/go#18203
[4] golang/go@5c2b5ee
[5] https://golang.org/doc/devel/release.html#go1.7.minor
[6] https://github.com/golang/go/issues?q=milestone%3AGo1.7.5
@smarterclayton @jwforres PTAL