Skip to content

Conversation

@smarterclayton
Copy link
Contributor

No description provided.

@smarterclayton smarterclayton force-pushed the rebase_kube branch 2 times, most recently from c4a4616 to 33a34e1 Compare March 19, 2015 17:23
@smarterclayton
Copy link
Contributor Author

[test]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1402/)

@smarterclayton smarterclayton force-pushed the rebase_kube branch 7 times, most recently from 18da154 to eeba91c Compare March 20, 2015 03:46
@smarterclayton
Copy link
Contributor Author

@soltysh @mfojtik can one of you investigate this in the morning - it looks like either the redirector on build logs or on pod logs has changed, and now build logs rest is broken (double setting the response).

ruby-sample-build-c9a03552-ceb0-11e4-8e9b-080027c5bfa9   STI                 Complete            build-ruby-sample-build-c9a03552-ceb0-11e4-8e9b-080027c5bfa9
[INFO] Success running command: 'osc get -n test builds | grep -i complete' after 258 seconds
[INFO] Build ruby-sample-build-c9a03552-ceb0-11e4-8e9b-080027c5bfa9 finished
F0320 03:30:02.702779    3919 buildlogs.go:41] Get http://http:/127.0.0.1:10250/containerLogs/test/build-ruby-sample-build-c9a03552-ceb0-11e4-8e9b-080027c5bfa9/sti-build: dial tcp: lookup http: no such host

@soltysh
Copy link
Contributor

soltysh commented Mar 20, 2015

I'll have a look at it right after planning.

@soltysh
Copy link
Contributor

soltysh commented Mar 20, 2015

@smarterclayton fixed in smarterclayton#9 With this I found that upstream adds currently http:// by default in the redirector (see here) but they didn't (see here)
It's flaky IMHO, they should allow you to set the Scheme for yourself, don't you think?

@smarterclayton
Copy link
Contributor Author

@liggitt owns making this work upstream because he's about to update the proxy to be secure to the backend (which is broken today in their model).

Thanks for the fix.

----- Original Message -----

@smarterclayton fixed in smarterclayton#9 With
this I found that upstream adds currently http:// by default in the
redirector (see
here)
but they didn't (see
here)
It's flaky IMHO, they should allow you to set the Scheme for yourself, don't
you think?


Reply to this email directly or view it on GitHub:
#1373 (comment)

@smarterclayton smarterclayton changed the title WIP - Rebase Kubernetes Rebase Kubernetes Mar 20, 2015
@smarterclayton smarterclayton changed the title Rebase Kubernetes Rebase Kubernetes onto 0.12 Mar 20, 2015
@smarterclayton
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1248/) (Image: devenv-fedora_1095)

@smarterclayton
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 940fc30

openshift-bot pushed a commit that referenced this pull request Mar 20, 2015
@openshift-bot openshift-bot merged commit 5a74a95 into openshift:master Mar 20, 2015
jboyd01 pushed a commit to jboyd01/origin that referenced this pull request Oct 17, 2017
…service-catalog/' changes from 3aacfedec6..aa27078754

aa27078754 origin build: add origin tooling
bcf37fd 0.1.0-rc2 chart updates (openshift#1410)
4ab0a0a add back 'Processing' message for instance deletion (openshift#1332)
0ecbcb1 Update logs for Cluster service plans. (openshift#1389)
8b491ef Fix a quoting nit (openshift#1400)
63685e4 add orphan mitigation-specific conditions for instances (openshift#1378)
adee662 Updated missed fields in service and plan specs (openshift#1406)
2095919 Handle default plan setting when using k8s names (openshift#1405)
607ba66 Document rbacEnable. (openshift#1404)
268294e Adding rbac definition for v1 api endpoint. (openshift#1284)
103288d differentiate between failed updates and provisions during deletion (openshift#1383)
eba8ba4 enable API aggregation and Service Catalog RBAC on Jenkins (openshift#1333)
5a93315 Validate relistDuration is non-negative (openshift#1395)
e279d21 Fix log messages for secrets (openshift#1385)
87fa8c9 fix status update when starting orphan mitigation (openshift#1372)
11f18f3 Switch to wget for integration apiserver checks (openshift#1384)
8c44a7d update OSB client to 2.13 (openshift#1392)
e64bbd1 default plan admission controller: filter list of service plans/service classes by the class name (openshift#1351)
6648c0e Check field names. Fix issue 1291 (openshift#1379)
5319841 update comment for instance generation check (openshift#1382)
7d5823f remove internal poll method (openshift#1381)
07d3068 Rework the logging for controller_instance. (openshift#1371)
5f4ca01 address PR comment as a followup (openshift#1380)
485d5e6 Add support for specifying plan using K8S names. (openshift#1377)
662bba8 Log number of secret keys created for binding credential (openshift#1375)
8ad6a31 Move controller constants into correct files (openshift#1373)
7bd66dd Adding type to log. (openshift#1339)
1ce5c4d Remove k8s/k8s dependency (openshift#1355)
b458323 Adding log formatting for BindingController. (openshift#1352)
275eb11 rename test variables to be consistent (openshift#1315)
ffd6b8b travis: skip cleanup before deploy (openshift#1368)
d5ecc04 fix travis tag checker (openshift#1365)
2cae0ee Minor updates to README (openshift#1360)
REVERT: 3aacfedec6 carry: Set external plan name for service-catalog walkthrough
REVERT: 3ec9e5b07a origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: aa2707875461dd51be3731b1d94b5cfc3b9a3976
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants