Resolve config file references relative to config file, add initial config validation #1340
Conversation
liggitt
changed the title
pkg/cmd/server/api/helpers.go
Outdated
There was a problem hiding this comment.
This and relativize paths are both generic, so moving them to cmdutil makes sense. We've already used similar logic in .kubeconfig file processing so we could collapse further into kube at some point.
|
It's a good starting point. Minor comments, once those are fixed its ready to merge. |
|
comments addressed, another commit added to put all the node certs (client and server) in a single dir in prep for node distribution |
|
You know, if you keep feeding it, it will get bigger.... |
|
lgtm |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1203/) (Image: devenv-fedora_1067) |
|
@deads2k switched to validating only when we actually start the master/node (for now), otherwise you can't write out config without minting certs, and it makes unit testing harder |
|
[merge] |
|
Evaluated for origin up to 972d88b |
Merged by openshift-bot
3 participants
@deads2k