Autogenerate route names if host is not specified - second version with plugin based allocator support

[ramr]

Autogenerate route names (if none is specified) using allocator plugins (currently defaults to using the simple single/unsharded router allocation scheme).

@smarterclayton / @pweil- PTAL - This is version 2 of the original PR : #1250

Unit tests pass (make check) and integration tested this with the sample app https://github.com/ramr/origin/tree/master/examples/sample-app - removing the "host" defined for the frontend in examples/sample-app/application-template-stibuild.json and getting one to autogenerate based on the service + namespace.

$ osc get -n test routes     
NAME                HOST/PORT                        PATH                SERVICE             LABELS    
route-edge          frontend-test.v3.openshift.com                       frontend            template=application-template-stibuild     

[smarterclayton]

It's ok to pass the regular pointer here

[ramr]

@smarterclayton - made the changes as per the review comments. See commit: 7e596f5

Updated integration test info:

$ osc get -n test routes       
NAME                HOST/PORT                       PATH                SERVICE             LABELS     
route-edge          frontend-test.openshift.local                       frontend            template=application-template-stibuild     

Thx.

[smarterclayton]

I just realized - if you make the default suffx "router.default.local" we can add something to the service the router command generates and auto resolve DNS to it. Oh wow.

Do that, let me look at the DNS gen and see if I can get wildcard to resolve quickly.

On Mar 12, 2015, at 4:05 PM, ramr [email protected] wrote:

@smarterclayton - made the changes as per the review comments. See commit: 7e596f5

Updated integration test info:

$ osc get -n test routes
NAME HOST/PORT PATH SERVICE LABELS
route-edge frontend-test.openshift.local frontend template=application-template-stibuild
Thx.

—
Reply to this email directly or view it on GitHub.

[pweil-]

nice!

[smarterclayton]

Paul, any final comments here? Does this fit with the long term sharding strat, or do you see anything fundamental we're missing?

[pweil-]

LGTM 👍 For actual sharded routers we can make a plugin that drives its config by being aware of routers and what shard keys they support.

[ramr]

Looks to be some UI failure or timeout. Retesting.

[ramr]

[test]

[abhgupta]

[test]

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1295/)

[smarterclayton]

LGTM [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1168/) (Image: devenv-fedora_1034)

[ramr]

@smarterclayton / @pweil- had to rebase due to git merge conflicts , can you please redo the merge - I don't have permissions. Thx.

[smarterclayton]

[merge]

[openshift-bot]

Evaluated for origin up to d0d6feb

[openshift-bot]

Origin Action Required: Please contact #openshift-dev to have this pull request manually reviewed and tested

[coveralls]

Changes Unknown when pulling d0d6feb on ramr:hostgen into * on openshift:master*.