Skip to content

Use GOFLAGS with go test - useful for debugging/passing down extra flags #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramr wants to merge 1 commit into from
Closed

Use GOFLAGS with go test - useful for debugging/passing down extra flags #1260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion hack/test-go.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,8 @@ if [[ -n "${KUBE_COVER}" && -n "${OUTPUT_COVERAGE}" ]]; then
fi
done
else
go test $KUBE_RACE $KUBE_TIMEOUT $KUBE_COVER "${@:2}" $test_packages
# Allow specific tests (e.g. TestRoute1) to be run via make.
# Example:
# make check WHAT=pkg/route/api/validation/ GOFLAGS="-v -run TestRoute1"
go test ${GOFLAGS:-} $KUBE_RACE $KUBE_TIMEOUT $KUBE_COVER "${@:2}" $test_packages
Copy link
Contributor

@smarterclayton smarterclayton Mar 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can already add your flags to the end via the "${@:2}" - i.e. you can run:

hack/test-go.sh pkg/foo -test.run=Bar -v

I'm not opposed to GOFLAGS, but it's already effectively covered.

Copy link
Contributor Author

@ramr ramr Mar 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - didn't see that. Will close this out then.

fi