-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Add DNS support to OpenShift #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d2fac8 to
e3565c6
Compare
|
[test] |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1256/) |
|
@deads2k review please |
|
A few (hopefully quick) questions:
|
|
Now you can run `source hack/export-certs.sh <path_to_cert_dir>` and the proper certs are set in your env
Need to work with go-systemd to see if we can abstract the syscall.CloseOnExec which is not supported on windows.
Nodes will now assume the master is a DNS server (unless OPENSHIFT_DNS_ADDR is set) and will pass that value in to the containers they run. The master will listen on 53 (if it can bind to it) or 8053 to serve DNS queries.
|
Comments addressed. |
|
lgtm [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1138/) (Image: devenv-fedora_1001) |
|
Evaluated for origin up to dc16de5 |
Still remaining - add e2e test for services.