Add cert validation option to requestheader #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liggitt
changed the title
Contributor
Author
17 tasks
Contributor
There was a problem hiding this comment.
Clarify. I think this is wrapping a RequestAuthenticator inside of another RequestAuthenticator that requires a valid client cert as opposed to pulling the user info from a client cert.
Contributor
Author
There was a problem hiding this comment.
This is the unified glog.Fatal for now
Contributor
Author
|
@deads2k comments addressed |
Contributor
|
lgtm [merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1143/) (Image: devenv-fedora_1007) |
Contributor
|
Evaluated for origin up to dcf2797 |
openshift-bot
pushed a commit
that referenced
this pull request
Mar 10, 2015
Merged by openshift-bot
Miciah
pushed a commit
to Miciah/origin
that referenced
this pull request
Jun 27, 2018
…vsphere UPSTREAM: 59440: Use SetInformers method to register for Node events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brenton fyi