Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 5, 2015

This allows build-logs to work for non-cluster admins. Fixes #1237

@liggitt @brenton

@deads2k
Copy link
Contributor Author

deads2k commented Mar 5, 2015

Fixes #1237

@liggitt
Copy link
Contributor

liggitt commented Mar 5, 2015

LGTM

@liggitt
Copy link
Contributor

liggitt commented Mar 5, 2015

Actually, might need the "proxy" verb as well

@deads2k
Copy link
Contributor Author

deads2k commented Mar 5, 2015

Actually, might need the "proxy" verb as well

Proxying for osc log pod-id builds a URL that tries to hit a minion, /api/v1beta1/proxy/minions/deads-dev-01/containerLogs/test/database-1-rsn1t/ruby-helloworld-database?follow=false. Since that is non-namespaced and we don't want project admins mucking around with minions, that is more difficult. I'll make sure we get a separate issue for it.

@deads2k
Copy link
Contributor Author

deads2k commented Mar 5, 2015

[merge]

@brenton
Copy link
Contributor

brenton commented Mar 5, 2015

@sdodson, we're going to want to cherry-pick this into beta2.

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1124/) (Image: devenv-fedora_983)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to d56d937

openshift-bot pushed a commit that referenced this pull request Mar 5, 2015
@openshift-bot openshift-bot merged commit 9e1ec1e into openshift:master Mar 5, 2015
@deads2k deads2k deleted the deads-add-redirect-to-viewers branch March 6, 2015 12:58
jboyd01 pushed a commit to jboyd01/origin that referenced this pull request Sep 20, 2017
…service-catalog/' changes from ae6b643caf..50e234de83

50e234de83 origin build: add origin tooling
092d7f8 Fix typos and resource names in walkthrough e2e logs (openshift#1237)
d25bd11 Archive the old agenda doc, link to new one (openshift#1243)
6192d14 fix lint errors (openshift#1242)
d103dad Fix lint errors and regenerate openapi (openshift#1238)
e9328d3 Broker Relist (openshift#1183)
b0f3222 Correct the reasons and messages set on the ready condition during async polling (openshift#1235)
d2bb82f Re-enable the href checker (openshift#1232)
2c29654 Use feature gates in controller-manager (openshift#1231)
699eab9 switch build to go1.9 (openshift#1155)
7529ed8 broker resource secret authorization checking (openshift#1186)
50d9bdf v0.0.20 chart updates (openshift#1228)
REVERT: ae6b643caf Use oc adm instead of oadm which might not exist in various installations.
REVERT: 66a4eb2a2c Update instructions... will remove once documented elsewhere
REVERT: 1b704d1530 replace build context setup with init containers
REVERT: ee4df18c7f hack/lib: dedup os::util::host_platform and os::build::host_platform
REVERT: 1cd6dfa998 origin: Switch out owners to Red Hatters
REVERT: 664f4d318f Add instructions for syncing repos
REVERT: 2f2cdd546b origin-build: delete files with colon in them
REVERT: cdf8b12848 origin-build: don't build user-broker
REVERT: ebfede9056 origin build: add _output to .gitignore
REVERT: 55412c7e3d origin build: make build-go and build-cross work
REVERT: 68c74ff4ae origin build: modify hard coded path
REVERT: 3d41a217f6 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: 50e234de836b5e7c9e3d7d763847b99a0f0ea500
jboyd01 pushed a commit to jboyd01/origin that referenced this pull request Sep 21, 2017
…service-catalog/' changes from ae6b643caf..06b897d198

06b897d198 origin build: add origin tooling
092d7f8 Fix typos and resource names in walkthrough e2e logs (openshift#1237)
d25bd11 Archive the old agenda doc, link to new one (openshift#1243)
6192d14 fix lint errors (openshift#1242)
d103dad Fix lint errors and regenerate openapi (openshift#1238)
e9328d3 Broker Relist (openshift#1183)
b0f3222 Correct the reasons and messages set on the ready condition during async polling (openshift#1235)
d2bb82f Re-enable the href checker (openshift#1232)
2c29654 Use feature gates in controller-manager (openshift#1231)
699eab9 switch build to go1.9 (openshift#1155)
7529ed8 broker resource secret authorization checking (openshift#1186)
50d9bdf v0.0.20 chart updates (openshift#1228)
REVERT: ae6b643caf Use oc adm instead of oadm which might not exist in various installations.
REVERT: 66a4eb2a2c Update instructions... will remove once documented elsewhere
REVERT: 1b704d1530 replace build context setup with init containers
REVERT: ee4df18c7f hack/lib: dedup os::util::host_platform and os::build::host_platform
REVERT: 1cd6dfa998 origin: Switch out owners to Red Hatters
REVERT: 664f4d318f Add instructions for syncing repos
REVERT: 2f2cdd546b origin-build: delete files with colon in them
REVERT: cdf8b12848 origin-build: don't build user-broker
REVERT: ebfede9056 origin build: add _output to .gitignore
REVERT: 55412c7e3d origin build: make build-go and build-cross work
REVERT: 68c74ff4ae origin build: modify hard coded path
REVERT: 3d41a217f6 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: 06b897d1988a5a3c035c5a971c15b97cbc732918
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
Miciah pushed a commit to Miciah/origin that referenced this pull request Jun 27, 2018
Revert "handle SIGINT/TERM in cmd/openshift"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

osc build-logs is blocked by the default policy

4 participants