-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable oss storage driver #12092
Enable oss storage driver #12092
Conversation
[test] |
@legionus we will have to make a second PR for 1.4 branch IMHO |
@mfojtik Let's merge this PR first. |
f00c95a
to
2884b70
Compare
@legionus I think you have change the commit message and split this to changing vendored dir commit and second that change the origin file. (to pass the commit checker) other than this LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please break into a bump commit and an origin commit. Everything else looks good to me
2884b70
to
3c24e0a
Compare
re[test] |
|
@mfojtik Damn. That's what happens when trying to do two PRs in same time. |
Signed-off-by: Gladkov Alexey <[email protected]>
3c24e0a
to
cc8ab12
Compare
@legionus are you working on this or should I go try to resolve the godep? |
Signed-off-by: Gladkov Alexey <[email protected]>
cc8ab12
to
02d5805
Compare
@mfojtik I've fixed it already. |
thx. lets make the test pass and open 1.4 branch pr |
[test] |
Evaluated for origin test up to 02d5805 |
@ncdc heads up for Godeps changes |
LGTM, including godep change |
[merge] flake: #12072 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11920/) (Base Commit: 7b90443) |
Flake #11004 |
yum repo flake [merge] |
Evaluated for origin merge up to 02d5805 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12006/) (Base Commit: 0158f35) (Image: devenv-rhel7_5486) |
Fix #11995
@mfojtik @pweil- please review