Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind moving this to its own line above as "export KUBECONFIG="? I don't think CERT_DIR is guaranteed to be set either - if you do make run it would be the current directory so you can do
export KUBECONFIG=$(pwd)/openshift.local.certificates/admin/.kubeconfig. @deads2k, withosc loginthis should be easier in the future, is there something simpler we can do to make this easy for a new user?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
On Wed, Mar 4, 2015 at 12:57 PM, Clayton Coleman notifications@github.com
wrote: