add gets and lists for roles and role bindings #1187
Conversation
There was a problem hiding this comment.
missing json for this and rolelist
|
ok, this was longer than I thought at first glace... will look Monday |
deads2k
force-pushed
the
deads-add-gets-lists
branch
from
0cf25fc to
b152b8d
Compare
|
rebased and comments addressed. |
There was a problem hiding this comment.
Feels wrong to potentially create an empty policy on a GET. That means a cluster-admin could call GetRole(namespace=bogus, foo) and end up with an empty policy in a previously non-existent namespace
|
Other than standardizing errors/error checking and avoiding policy creates on Get/Delete/failed Update, LGTM |
|
comments addressed. |
There was a problem hiding this comment.
apply label selector filter?
deads2k
force-pushed
the
deads-add-gets-lists
branch
from
9215fbe to
e84baee
Compare
|
LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1154/) (Image: devenv-fedora_1018) |
deads2k
force-pushed
the
deads-add-gets-lists
branch
from
e84baee to
a087ee7
Compare
|
needed a rebase to see a broken test. re[merge] |
deads2k
force-pushed
the
deads-add-gets-lists
branch
from
a087ee7 to
c25b5f2
Compare
|
transient? UI e2e failure. [merge] |
|
assets fixed. re[merge] |
|
Evaluated for origin up to c25b5f2 |
Merged by openshift-bot
…-describe UPSTREAM: 59701: Display pvc conditions with describe command
4 participants
adds gets and lists for the virtual policy resources, along with describers and printers. It also neatens up the virtual registry for roles.