Specify UI bind address in integration tests #1176
Conversation
|
[test] |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1203/) |
pkg/cmd/server/config.go
Outdated
There was a problem hiding this comment.
Seems like the default port for the assetPublicAddr should be assetBindAddr port. That would allow it to do match defaulting for masterPublicAddr (directly specified, masterAddr if specified, bindAddr).
There was a problem hiding this comment.
if I was exposing the asset stuff via flags, I'd agree... maybe I'll just add that
There was a problem hiding this comment.
if I was exposing the asset stuff via flags, I'd agree... maybe I'll just add that
may as well, it's easy to unit test :)
|
@deads2k I'd like to expose the UI config to the command line as a second step... mostly want to get this in to prevent test breakages at the moment |
|
lgtm [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1071/) (Image: devenv-fedora_929) |
|
Evaluated for origin up to 7c3bbef |
Merged by openshift-bot
3 participants
No description provided.