WIP: Added STI onbuild example #1162
Conversation
|
@bparees with modified run.sh, the ruby sample app works well also on the official Docker ruby:2.1-onbuild image. |
mfojtik
force-pushed
the
onbuild-sample-app
branch
from
3354059 to
78b9274
Compare
|
nice job @mfojtik 🎱 |
|
@mfojtik the environment file support changes to STI haven't been rebased into origin yet, have they... unfortunately that's breaking my attempt to demo both that feature and the onbuild feature (since the onbuild feature relies on the RACK env being set). i'm going hack the run.sh script in my demo repo for now to get around this. |
|
@bparees all changes required to support env are rebased to origin. @mfojtik https://github.com/mfojtik the environment file support changes i'm going hack the run.sh script in my demo repo for now to get around this. — |
|
@bparees we merged them yesterday.... try to update sti builder image |
|
@bparees do you want this merged? I think the support for all things that this example uses is already merged (and released?) |
There was a problem hiding this comment.
can you change this to use the openshift ruby-hello-world?
|
@bparees I think this PR pretty much out of sync with changes in OpenShift. I would vote for closing this as we already have STI example and the onbuild is just one of the STI strategies now. |
|
sure. |
…service-catalog/' changes from ef63307bdb..ae6b643caf ae6b643caf Use oc adm instead of oadm which might not exist in various installations. 66a4eb2a2c Update instructions... will remove once documented elsewhere 1b704d1530 replace build context setup with init containers ee4df18c7f hack/lib: dedup os::util::host_platform and os::build::host_platform 1cd6dfa998 origin: Switch out owners to Red Hatters 664f4d318f Add instructions for syncing repos 2f2cdd546b origin-build: delete files with colon in them cdf8b12848 origin-build: don't build user-broker ebfede9056 origin build: add _output to .gitignore 55412c7e3d origin build: make build-go and build-cross work 68c74ff4ae origin build: modify hard coded path 3d41a217f6 origin build: add origin tooling a8fc27d Fix typos in walkthrough (openshift#1224) e77edbf openshift#1157: Limit the amount of time for reconciliations (openshift#1196) 1b1a749 temporarily disabled verify-links.sh from the verify target (openshift#1226) acf8fab Send originating identity headers in OSB requests (openshift#1162) 821ba16 new admission controller to block updates to service instance updates that (openshift#1210) d69c5e5 Minor improvement to godoc in binaries (openshift#1211) 5b81814 fix typos (openshift#1221) 836dc4a Adds how to download Helm chart (charts/catalog) (openshift#1219) 2fd0115 Fix "visit the project on github" link. (openshift#1217) 325e4b6 Add how to set $GOPATH. (openshift#1218) 68b775f Update the installation (openshift#1199) 6e3a3c1 v0.0.19 (openshift#1207) 8b69791 Removing errexit from TLS setup script (openshift#1206) 273260f Instance deletion lifecycle enhancements, issue openshift#820 (openshift#1159) c050713 fix cleaning of build output for non-root users (openshift#1205) 5995df1 Merge branch 'pr/1204' 72f4802 Remove osb prefix from example ServiceClass (openshift#1201) f9dbd4e pin all dependencies in glide to current version except for glog where we want to pick up the prior version to fix issue 1187. f148bc5 v0.0.18 (openshift#1202) b86ab8d Removing the helm install command (openshift#1185) 3cff482 Remove Alpha* prefix on all API fields for issue openshift#1180 (openshift#1184) 154b74d Fix gofmt issue (openshift#1192) 2ee894a do the clean before building an arch (openshift#1179) b4976ef Fix bad URL (openshift#1189) cd3dede Fix hrefs again (openshift#1190) f066226 Design: Instance/Binding parameters (openshift#1075) eb37682 This generated file is missing from master (openshift#1191) 28c0ae7 Use generation instead of checksum for Instances and InstanceCredentials (openshift#1151) 5cdd323 Fix bad href (openshift#1188) 8a892f0 handle lingering polling cases (openshift#1174) f5fabd6 remove TPRs from Jenkins e2e pipeline (openshift#1175) 717df78 Add godoc explaining that Instance and InstanceCredential specs are immutable (openshift#1182) REVERT: ef63307bdb origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: ae6b643cafd3a17412f173e70ed7c1a2e39ee549
* Send, in OSB requests, the originating identity of the user that performed the action on the resource. * Code review feedback * Add comment to CheckGracefulDelete functions indicating that our use of them is a hack.
[3.9] setup binary input for custom builds properly
5 participants
No description provided.