make start.config non-mutating, fix --kubeconfig handling

[liggitt]

Extension of #1128

@smarterclayton this is worthwhile to get in now:

• makes the 11,000,000 different ways of running openshift start testable
• lets you trigger external kubernetes mode with either --kubernetes=... or --kubeconfig=...
• prevents credentials in --kubeconfig from being sent to the wrong server if --kubernetes was also set and pointed somewhere else
• lays the groundwork for separating start into stages later (input stage, host calculation/defaulting stage, bootstrapping/cert generation stage, execute stage)

[liggitt]

[test]

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1179/)

[liggitt]

@deads2k review my commits?

[deads2k]

Well, my schedule definitely didn't include 2am... :)

[deads2k]

I like it. I just want to make sure I can launch it in an integration test and then I'd say it's good.

[smarterclayton]

On Feb 25, 2015, at 11:24 PM, Jordan Liggitt [email protected] wrote:

Extension of #1128

@smarterclayton this is worthwhile to get in now:

makes the 11,000,000 different ways of running openshift start testable
Citation needed
lets you trigger external kubernetes mode with either --kubernetes=... or --kubeconfig=...
prevents credentials in --kubeconfig from being sent to the wrong server if --kubernetes was also set and pointed somewhere else
lays the groundwork for separating start into stages later (input stage, host calculation/defaulting stage, bootstrapping/cert generation stage, execute stage)
You can view, comment on, or merge this pull request online at:

#1156

Commit Summary

make start.config immutable
Rework --kubeconfig handler, misc tweaks
Ensure create of master policy namespace happens after policy will allow it
File Changes

M hack/test-end-to-end.sh (4)
M pkg/cmd/openshift/openshift.go (3)
A pkg/cmd/server/command.go (129)
A pkg/cmd/server/command_test.go (304)
A pkg/cmd/server/config.go (299)
A pkg/cmd/server/config_test.go (418)
M pkg/cmd/server/crypto/crypto.go (16)
A pkg/cmd/server/kube_master.go (60)
A pkg/cmd/server/node_config.go (37)
A pkg/cmd/server/origin/config.go (208)
M pkg/cmd/server/origin/master.go (113)
A pkg/cmd/server/origin_master.go (424)
M pkg/cmd/server/start.go (825)
D pkg/cmd/server/start_test.go (34)
Patch Links:

https://github.com/openshift/origin/pull/1156.patch
https://github.com/openshift/origin/pull/1156.diff
—
Reply to this email directly or view it on GitHub.

[deads2k]

Citation needed

Authorization integration tests are needed and this fix makes it easy to do. By clearly splitting responsibilities in start.go, we were able to write a series of unit tests to catch edges, both on general defaulting and on the bindings of those config values to the command line.

[smarterclayton]

That was a joke on the 11 million

On Feb 26, 2015, at 6:13 AM, David Eads [email protected] wrote:

Citation needed

Authorization integration tests are needed and this fix makes it easy to do. By clearly splitting responsibilities in start.go, we were able to write a series of unit tests to catch edges, both on general defaulting and on the bindings of those config values to the command line.

—
Reply to this email directly or view it on GitHub.

[smarterclayton]

See comments, otherwise this looks like an excellent refactoring, thank you David and Jordan

[liggitt]

comments addressed, squashed as much as I plan to (david's together for credit/blame, mine together for credit/blame, two small unrelated fixes as separate commits)

[deads2k]

lgtm [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1048/) (Image: devenv-fedora_904)

[deads2k]

the test worked, probably a transient. re[merge]

[openshift-bot]

Evaluated for origin up to 35ff8be